[EuiSuperDatePicker] Emotion conversion button fixes#7911
Merged
cee-chen merged 4 commits intoelastic:mainfrom Jul 25, 2024
Merged
[EuiSuperDatePicker] Emotion conversion button fixes#7911cee-chen merged 4 commits intoelastic:mainfrom
cee-chen merged 4 commits intoelastic:mainfrom
Conversation
- should be cut off instead like production
cee-chen
added
the
skip-changelog
13 tasks
mgadewoll
approved these changes
Jul 25, 2024
Contributor
mgadewoll
left a comment
mgadewoll
left a comment
There was a problem hiding this comment.
🚢 🐈⬛ Thanks for the quick fix!
Contributor
Author
|
The wrapping fix isn't quite working as expected on mobile - please hold 😬 |
- Fix input width bouncing by adding `overflow: hidden` to range wrapper - remove unnecessary `display: flex`, buttons automatically adjust based on height: 100%. Requires switching to `text-align` instead for pretty format - add `text-overflow: ellipsis` for clearer and more consistent truncation
- not totally sure what changed!!
Collaborator
💚 Build Succeeded
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #7904 - @mgadewoll noticed a few visual regressions in the changes in that PR after it merged, which this one should fix.
QA
General checklist
and screenreader modes