Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Convert EuiSaturation and EuiHue #7859

Merged
merged 13 commits into from
Jun 27, 2024
Merged

[Emotion] Convert EuiSaturation and EuiHue #7859

merged 13 commits into from
Jun 27, 2024

Commits on Jun 26, 2024

  1. [EuiSaturation] Set up Emotion file

    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    34676e5 View commit details
    Browse the repository at this point in the history

  2. [EuiSaturation] Convert lightness and saturation gradients 

    - remove Sass variables - I don't see a reason to keep them as they're not being reused anywhere and don't need to be overridden
    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    07e019a View commit details
    Browse the repository at this point in the history

  3. [EuiSaturation] Convert indicator styles 

    - simplify negative margins to transform translates
    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    20e852d View commit details
    Browse the repository at this point in the history

  4. [EuiSaturation] Convert focus styles 

    + standardize mouse vs keyboard focus indicators

+ delete Sass files
    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5ead1cb View commit details
    Browse the repository at this point in the history

  5. [EuiSaturation] Misc cleanup 

    - move classes/styles to top of file

- convert inline position styles to logical properties

- memoize various functions

- fix IDs potentially being invalid if no `id` prop is passed
    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7c51ca5 View commit details
    Browse the repository at this point in the history

  6. [EuiHue] Set up Emotion file

    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    11b48c2 View commit details
    Browse the repository at this point in the history

  7. [EuiHue] Convert range indicator to Emotion 

    - Remove now-unnecessary IE/moz resets

- Simplify focus/visible styles, overrides, etc

- remove unnecessary z-index and euiCustomControl mixin, replace `top` offset with negative margin
    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    01a6422 View commit details
    Browse the repository at this point in the history

  8. Delete Sass files

    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    82ce5dc View commit details
    Browse the repository at this point in the history

  9. Tests

    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    187a1f6 View commit details
    Browse the repository at this point in the history

  10. stylelint shenanigans 

    :| legitimately not sure what on earth is going on with the indicator styles, I think the nested template literal is throwing stylelint for a loop
    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e01b4cf View commit details
    Browse the repository at this point in the history

  11. changelog

    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    4fd5ce6 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Merge branch 'emotion/color-pickers' into emotion/color-picker-5

    @cee-chen
    cee-chen committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    5e7fc14 View commit details
    Browse the repository at this point in the history

  2. Final Sass file deletion

    @cee-chen
    cee-chen committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6941e9e View commit details
    Browse the repository at this point in the history