[EuiFormControlLayout] Convert from class to function component#7803
Merged
cee-chen merged 4 commits intoelastic:emotion/formsfrom Jun 4, 2024
Merged
Conversation
…omponent - which will allow us to more easily use hooks etc for styles
cee-chen
force-pushed
the
emotion/form-layout-functional-component
branch
from
36faa96 to
c6473d5
Compare
mgadewoll
approved these changes
Jun 4, 2024
Contributor
There was a problem hiding this comment.
Awesome call to migrate to a function component! 👏 Looks nice and clean to me and seems to be working as expected ✅
I only left a small comment, I approve this PR already in case it's actually expected to not have a default value for iconsPosition anymore 🙂
packages/eui/src/components/form/form_control_layout/form_control_layout.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co>
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note
This PR merges into a feature branch.
This tech debt will allow us to more easily use hooks for Emotion styles in a future PR.
QA
General checklist
N/A, tech debt only