-
Notifications
You must be signed in to change notification settings - Fork 896
[EuiDataGrid][BugFix]: Fix visible overflowing truncated text #7793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cee-chen
merged 14 commits into
elastic:main
from
mgadewoll:datagrid/7780-fix-visible-truncated-text-fontsize-s
Jun 5, 2024
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
64b9fc8
fix: prevent truncated text from showing
mgadewoll 9d2ffef
docs(storybook): add specific row height story
mgadewoll 8bf1bbe
test(VRT): add reference images
mgadewoll 4e4ca05
chore: add changelog
mgadewoll d38aa3e
refactor: revert style changes
mgadewoll 7553f40
fix: add additional wrapper and split styles
mgadewoll 25c4c71
docs(storybook): add additional stories for row height specific settings
mgadewoll 48c934f
test(VRT): add reference images for new stories
mgadewoll c47968c
test: update snapshots
mgadewoll 3f67373
refactor(EuiDataGrid): add Cees suggestion to use transparent border
mgadewoll 742961a
test: revert snapshots
mgadewoll de2cfd5
fix: ensure gridStyle fontSize and cellPadding trigger recalculation …
mgadewoll 9f0996d
chore: revert gridStyles update fix
mgadewoll bce20ea
changelog copy tweak
cee-chen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+49.6 KB
...oki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Custom_Row_Heights.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+45.4 KB
...loki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Height_Line_Count.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+52.2 KB
...s/eui/.loki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Row_Height.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+76.8 KB
...loki/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Custom_Row_Heights.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+71.8 KB
....loki/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Height_Line_Count.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+84.5 KB
...es/eui/.loki/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Row_Height.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| **Bug fixes** | ||
|
|
||
| - Fixed a visual bug on `EuiDataGrid` cells when using `rowHeightOptions.defaultHeight.lineCount` where the clamped text was still visible for some font sizes | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.