[Storybook] Add stories for more components (form components) - Part 1#7781
Merged
cee-chen merged 17 commits intoelastic:mainfrom May 30, 2024
Merged
[Storybook] Add stories for more components (form components) - Part 1#7781cee-chen merged 17 commits intoelastic:mainfrom
cee-chen merged 17 commits intoelastic:mainfrom
Conversation
- adds additional controls for props
- add support for excluding stories from the sidebar menu - update jsdoc on EuiSwitch
mgadewoll
added
documentation
- Storybook only allows strings directly as tags. pffft. meh.
cee-chen
reviewed
May 30, 2024
cee-chen
reviewed
May 30, 2024
packages/eui/src/components/form/text_area/text_area.stories.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
May 30, 2024
cee-chen
reviewed
May 30, 2024
cee-chen
reviewed
May 30, 2024
cee-chen
reviewed
May 30, 2024
cee-chen
reviewed
May 30, 2024
cee-chen
reviewed
May 30, 2024
packages/eui/src/components/form/field_password/field_password.stories.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
May 30, 2024
packages/eui/src/components/form/field_password/field_password.stories.tsx
Show resolved
Hide resolved
cee-chen
reviewed
May 30, 2024
packages/eui/src/components/form/field_search/field_search.stories.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
I think the above were all my comments! Awesome job and thank you for this, this is going to be terrifically helpful for my Emotion conversions! |
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
|
cee-chen
approved these changes
May 30, 2024
Contributor
cee-chen
left a comment
cee-chen
left a comment
There was a problem hiding this comment.
Changes look great!! Going to go ahead and approve + merge this in so I can use this in my feature branch/PRs! 👿
This was referenced Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
relates to #7614
This PR adds more stories for form components:
It also adds small updates for the existing stories of the following components:
Additionally this PR adds base VRT reference images based on the added stories.
QA