[Fix] Revert removed setTimeout on EuiInputPopover scroll listener#7760
Merged
mgadewoll merged 4 commits intoelastic:mainfrom May 15, 2024
Merged
Conversation
cee-chen
reviewed
May 15, 2024
cee-chen
reviewed
May 15, 2024
tkajtoch
reviewed
May 15, 2024
Member
tkajtoch
left a comment
There was a problem hiding this comment.
I tested the changes locally and verified it fixes kibana tests. I'm happy to get this merged when Cee's comments are addressed :)
cee-chen
approved these changes
May 15, 2024
Contributor
cee-chen
left a comment
There was a problem hiding this comment.
Thanks so much for hopping on this Lene! Also, looking forward to when we can more frequently run EUI against Kibana CI to catch issues like this that only crop up in test environments 😭
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #7761
This PR reverts earlier changes done in this PR which remove a
setTimeoutonEuiInputPopover's scroll listener.This change triggered flaky e2e test behaviors in Kibana (observed from version
94.3.0).QA
Verifying fix on Kibana
gh pr checkout 7760packages/euiwithyarn build-packyarn es snapshot,yarn kbn bootstrap --no-validate && yarn start)security_solutiontest directory and run the cypress testsrule_creation/common_flows.cy.tsto runVerifying Firefox issue around unexpectedly closing combobox panel on hover is still fixed
🔗 Issue conversation
EuiComboBoxin FirefoxEuiComboBoxfor opening the popover panel