[EuiFlyoutResizable] Fix onResize not appearing in props table
#7750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it must be inheriting from HTML attributes somewhere?? so we need to omit it - move resizable specific props above generic flyout props in table also
cee-chen
added
documentation
mgadewoll
reviewed
May 13, 2024
Contributor
Author
|
Not sure what's up with the hanging GH jobs, going to admin merge |
Contributor
Author
|
Oh wait lol it won't let me. Githuuuuub!! |
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@PhilippeOberti super helpfully pointed out that the
onResizeprop added in #7464 doesn't actually show up in the props table 🤦QA
onResizein its props tableGeneral checklist
@defaultif default values are missing)and playground toggles