[changelogs] Add an accessibility prompt/heading to yo generator#7742
Merged
cee-chen merged 1 commit intoelastic:mainfrom May 7, 2024
Merged
[changelogs] Add an accessibility prompt/heading to yo generator#7742cee-chen merged 1 commit intoelastic:mainfrom
yo generator#7742cee-chen merged 1 commit intoelastic:mainfrom
Conversation
1Copenut
approved these changes
May 7, 2024
Contributor
1Copenut
left a comment
There was a problem hiding this comment.
👍 Thank you for adding this prompt!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The discussion in #7740 (comment) inspired me to update our
yarn yo-changeloggenerator util to include a prompt and generated heading for a11y improvements, now that we have more folks contributing to that area! 🎉 🥳We've historically already been using the
**Accessibility**heading in any case for changelog, this just makes it more official and easier for new contributors to find.QA
yarn yo-changelog 1and type Y for the accessibility prompt, confirm the output.mdlooks as expected with the correct headingGeneral checklist
N/A, dev only change