[Emotion] Convert EuiMarkdownEditor#7738
Merged
cee-chen merged 17 commits intoelastic:mainfrom May 7, 2024
Merged
Conversation
- remove unnecessary `margin-bottom !important` - doesn't appear to be doing anything whatsoever
+ export new/internal `isNamedColor` util from EuiTextColor
- move them from global CSS to the specific plugin/renderer + DRY out readonly CSS by moving it to the default checkbox component styles, and setting the actual inputs to `readonly` (which is significantly more accessible to screen readers)
+ merge amsterdam overrides + merge preview styles, doesn't have a separate component + start component variables fn
- skip param args in favor of CSS variables (much cleaner all around) - these utils may need some more cleanup as I move into the actual forms conversions, but they're probably Good Enough for now
- look at that CSS variable in action! wowowow note: I'm skipping reducing nesting specificity and !importants for this component because its ownership is kind of up in the air and it's probably not worth the time right now
- not sure why this wasn't already the case in prod, so making this opinionated change now
+ replace an unnecessary snapshot with an assertion
cee-chen
changed the title
EuiMarkdownEditor
mgadewoll
reviewed
May 7, 2024
src/components/markdown_editor/markdown_editor_toolbar.styles.ts
Outdated
Show resolved
Hide resolved
css is cool y'all
mgadewoll
reviewed
May 7, 2024
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
mgadewoll
approved these changes
May 7, 2024
Contributor
mgadewoll
left a comment
mgadewoll
left a comment
There was a problem hiding this comment.
🚢 🐈⬛ Thanks for the fixes and clarifying the comments! It works nicely now 🎉
Contributor
Author
|
Thanks as always for the amazing QA Lene, you rock! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #6402
(in this case, some forms mixins needed to be converted from Sass to Emotion anyway, so I figured... ah what the heck, I can make do a little cleanup while here. as a treat.)
As always, please follow along by commit (or just skip to the QA portion).
QA
No visual regressions for the following UI/UX:
EuiMarkdownFormat:
accent,success,blue), and make sure the checkboxes and tooltips look the same as beforeEuiMarkdownEditor:
NOTE: The toolbar/footer bg colors changed slightly. I have no idea why because they're both using
lightestShade. I think Caroline changed this in the Sass->Emotion work.Checklist
See the Emotion conversion checklist in #6402