Skip to content

[EuiSearchBar] Allow @ special character in query string searches #7702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cee-chen merged 2 commits into from
Apr 23, 2024
Merged

[EuiSearchBar] Allow @ special character in query string searches #7702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e78eb8
Allow `@` special character in query string searches
cee-chen Apr 22, 2024
5e01735
changelog
cee-chen Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/upcoming/7702.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Updated `EuiSearchBar` to allow the `@` special character in query string searches
4 changes: 2 additions & 2 deletions src/components/search_bar/query/default_syntax.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,12 +871,12 @@ describe('defaultSyntax', () => {
});

test('special characters', () => {
const ast = defaultSyntax.parse('*_-:');
const ast = defaultSyntax.parse('*_-:@');
const clauses = ast.getTermClauses();
expect(clauses).toEqual([
{
type: 'term',
value: '*_-:',
value: '*_-:@',
match: 'must',
},
]);
Expand Down
2 changes: 1 addition & 1 deletion src/components/search_bar/query/default_syntax.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ word

wordChar
= alnum
/ [-_*:/]
/ [-_*:/@]
/ escapedChar
/ extendedGlyph

Expand Down