Skip to content

Conversation

@cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Feb 2, 2024

Summary

closes #7500

The text color broke in #7298, as part of this changelog item:

  • Fixed EuiListGroupItem to pass style props to the wrapping <li> element alongside className and css. All other props will be passed to the underlying content.

The contrast page was passing style to EuiListGroupItem and relying it to go onto the <button> element instead of the <li>. This broken the inherited color styling of the various button(s).

While here I also noticed a whole lot of other things going wrong with this page (😅) and pushed up several fixes - see the commit history.

QA

General checklist

  • Browser QA
    - [ ] Checked in mobile
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
    • Checked in both light and dark modes
    • Checked in Chrome, Safari, Edge, and Firefox
  • Docs site QA - See QA steps
  • Code quality checklist - N/A
  • Release checklist - N/A, docs only
  • Designer checklist - N/A

@cee-chen cee-chen added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) labels Feb 2, 2024
@cee-chen cee-chen force-pushed the docs/list-group-item branch from a574c48 to eb644ae Compare February 2, 2024 19:49
@cee-chen cee-chen changed the title [docs] Contrast page: fix EuiListGroupItem default button color overriding parent style [docs] Fix Colors > contrast docs page Feb 2, 2024
@cee-chen cee-chen changed the title [docs] Fix Colors > contrast docs page [docs] Fix Colors > Contrast docs page Feb 2, 2024
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@cee-chen cee-chen marked this pull request as ready for review February 2, 2024 21:03
@cee-chen cee-chen requested a review from a team as a code owner February 2, 2024 21:03
Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@cee-chen cee-chen merged commit 2477e79 into elastic:main Feb 2, 2024
@cee-chen cee-chen deleted the docs/list-group-item branch February 2, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The contrast examples on the Theming>Colors page seem to be broken

4 participants