[EuiCombobox]: Added a rule to reset margin on compressed plain text pills.#6910
Merged
1Copenut merged 4 commits intoelastic:mainfrom Jul 6, 2023
1Copenut:bug/euiCombobox-vertical-centering-6899
Merged
[EuiCombobox]: Added a rule to reset margin on compressed plain text pills.#69101Copenut merged 4 commits intoelastic:mainfrom 1Copenut:bug/euiCombobox-vertical-centering-6899
1Copenut merged 4 commits intoelastic:mainfrom
1Copenut:bug/euiCombobox-vertical-centering-6899
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6910/ |
cee-chen
reviewed
Jul 6, 2023
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
cee-chen
reviewed
Jul 6, 2023
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
cee-chen
approved these changes
Jul 6, 2023
Contributor
cee-chen
left a comment
cee-chen
left a comment
There was a problem hiding this comment.
Super clean and elegant fix Trevor! 🎉 I think it'll transcribe well to Emotion too when that time comes!
andreadelrio
approved these changes
Jul 6, 2023
Contributor
andreadelrio
left a comment
andreadelrio
left a comment
There was a problem hiding this comment.
LGTM 🎉 Thanks for the quick fix!
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6910/ |
cee-chen
added a commit
to elastic/kibana
that referenced
this pull request
Jul 14, 2023
## Summary `eui@83.1.0` ⏩ `eui@84.0.0` --- ## [`84.0.0`](https://github.com/elastic/eui/tree/v84.0.0) - Updated `EuiDualRange`'s `minInputProps` and `maxInputProps` to support passing more props to underlying inputs ([#6902](elastic/eui#6902)) - `EuiFocusTrap` now supports configuring cross-iframe focus trapping via the `crossFrame` prop ([#6908](elastic/eui#6908)) **Bug fixes** - Fixed `EuiFilterButton` icon display ([#6900](elastic/eui#6900)) - Fixed `EuiCombobox` compressed plain text display ([#6910](elastic/eui#6910)) - Fixed visual appearance of collapse buttons on collapsible `EuiResizablePanel`s ([#6926](elastic/eui#6926)) **Breaking changes** - `EuiFocusTrap` now defaults to *not* trapping focus across iframes ([#6908](elastic/eui#6908)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@andreadelrio identified a bug where the compressed
EuiComboxplain text pills were not aligned vertically. I added a rule to target these pills specifically and adjust the vertical margin.PR closes #6899.
QA
General checklist
Props have proper autodocs (using@defaultif default values are missing) and playground togglesAdded documentationAdded or updated jest and cypress testsUpdated the Figma library counterpart