feat(DragAndDrop): Switch from react-beautiful-dnd to its fork @hello-pangea/dnd #6868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
jenkins test it please |
cee-chen
reviewed
Jun 22, 2023
| ); | ||
|
|
||
| expect(takeSnapshot(appDiv)).toMatchSnapshot(); | ||
| expect(screen.getByTestSubject('draggable')).toBeVisible(); |
Contributor
There was a problem hiding this comment.
Really love how much the new fork cleaned up our tests!
I think I'd like to leave in just one it renders snapshot here to get a sense of the DOM output. What do you think?
Member
Author
There was a problem hiding this comment.
Yeah that makes sense. I added it :)
cee-chen
approved these changes
Jun 22, 2023
Contributor
cee-chen
left a comment
cee-chen
left a comment
There was a problem hiding this comment.
Leaving my above comment as optional - if you're good with one it renders snapshot, feel free to make the change and merge it in. If not, merge away :)
…and rename test cases
tkajtoch
added a commit
that referenced
this pull request
Jul 11, 2023
…-pangea/dnd (#6868) * feat(DragAndDrop): Switch from react-beautiful-dnd to its fork @hello-pangea/dnd * test(EuiDraggable): add snapshot test for the basic render assertion and rename test cases
tkajtoch
added a commit
that referenced
this pull request
Jul 24, 2023
…-pangea/dnd (#6868) * feat(DragAndDrop): Switch from react-beautiful-dnd to its fork @hello-pangea/dnd * test(EuiDraggable): add snapshot test for the basic render assertion and rename test cases
tkajtoch
added a commit
that referenced
this pull request
Jul 26, 2023
…-pangea/dnd (#6868) * feat(DragAndDrop): Switch from react-beautiful-dnd to its fork @hello-pangea/dnd * test(EuiDraggable): add snapshot test for the basic render assertion and rename test cases
tkajtoch
added a commit
that referenced
this pull request
Jul 28, 2023
…-pangea/dnd (#6868) * feat(DragAndDrop): Switch from react-beautiful-dnd to its fork @hello-pangea/dnd * test(EuiDraggable): add snapshot test for the basic render assertion and rename test cases
tkajtoch
added a commit
that referenced
this pull request
Jul 31, 2023
…-pangea/dnd (#6868) * feat(DragAndDrop): Switch from react-beautiful-dnd to its fork @hello-pangea/dnd * test(EuiDraggable): add snapshot test for the basic render assertion and rename test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
react-beautiful-dndis in maintenance mode and doesn't support React 18 or StrictMode. This PR fixes #6187 and switches to using a forked and maintained version of RBD -@hello-pangea/dnd. Both packages share the same API and are cross-compatible as long as EUI consumers aren't importing DND elements from both EUI and react-beautiful-dnd.QA
yarnandyarn startThis code doesn't pass type checking because of differences in types between
@types/react@17and@types/react@18. This will be fixed when #6827 is merged tofeature/react-18and/or in following PRs.General checklist