Skip to content

[EuiTable] Remove overflow/height animation causing Safari cross-browser issues #6826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cee-chen merged 5 commits into from
Jun 2, 2023
Merged

[EuiTable] Remove overflow/height animation causing Safari cross-browser issues #6826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2cf575
[REVERT ME] Bug repro
cee-chen Jun 2, 2023
29b897b
Remove problematic animation/overflow
cee-chen Jun 2, 2023
e8d15c1
changelog
cee-chen Jun 2, 2023
d9ffc21
[PR feedback] Animation easing
cee-chen Jun 2, 2023
be01ea5
Revert "[REVERT ME] Bug repro"
cee-chen Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/components/table/_table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,22 +227,20 @@
}

// Animate expanded row must be on the contents div inside

// This adds a quick pop in animation, but does not attempt to animate to height auto
// - down that road dragons lie. @see https://github.com/elastic/eui/issues/6770
.euiTableRow-isExpandedRow .euiTableCellContent {
overflow: hidden;
animation: $euiAnimSpeedNormal $euiAnimSlightResistance 1 normal forwards growExpandedRow;
animation: $euiAnimSpeedFast $euiAnimSlightResistance 1 normal none growExpandedRow;
}

@keyframes growExpandedRow {
0% {
max-height: 0;
}

99% {
max-height: 100vh;
opacity: 0;
transform: translateY(-$euiSizeM);
}

100% {
max-height: unset;
opacity: 1;
transform: translateY(0);
}
}
3 changes: 3 additions & 0 deletions upcoming_changelogs/6826.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed the expanded row animation on `EuiBasicTable` causing cross-browser Safari issues