Skip to content

[EuiInlineEdit] Final screen reader / a11y polish pass #6805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cee-chen merged 6 commits into from
May 25, 2023
Merged

[EuiInlineEdit] Final screen reader / a11y polish pass #6805

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b9fe8b5
Fix conditional readonly aria-describedby
cee-chen May 23, 2023
f8ba007
Prevent double heading roles when readonly
cee-chen May 23, 2023
bd4118c
(hopefully) Fix enter screen reader behavior
cee-chen May 23, 2023
0f483bd
Fix VO announcing EuiInlineEditText as `clickable` in read only mode
cee-chen May 23, 2023
9cbb8a2
Revert "Fix VO announcing EuiInlineEditText as `clickable` in read on…
cee-chen May 25, 2023
3c4deb3
NVDA browser mode fix
cee-chen May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/inline_edit/inline_edit_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ export const EuiInlineEditForm: FunctionComponent<EuiInlineEditFormProps> = ({
saveInlineEditValue();
break;
case keys.ESCAPE:
event.preventDefault(); // NVDA will trigger Browse mode otherwise
Copy link
Contributor

@1Copenut 1Copenut May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing, this fix isn't changing NVDA's behavior, but that's okay. I tested NVDA on a basic input form on MDN's docs pages for a benchmark, and found the "two-step" process to be native behavior.

If a user is moving through the page using arrow keys, NVDA doesn't automatically toggle to Focus made and let users enter text into an input. They must press Enter to kick the screen reader into Focus mode to type into the input. Pressing ESC toggles the screen reader back to Browser mode at this point.

Your implementation is following native behavior, so I don't see a need to make a change from what's being done here.

Copy link
Contributor Author

@cee-chen cee-chen May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah - if it's not affecting NVDA or doing anything, I should remove the line in that case. Will push up a reversion in the main feature branch

Copy link
Contributor

@1Copenut 1Copenut May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the nature of screen reader testing. Try, fix, revert, try again. :)

cancelInlineEdit();
break;
}
Expand Down