Skip to content

[EuiInlineEdit] CHANGELOG & Copy Linting #6788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
breehall merged 2 commits into from
May 18, 2023
Merged

[EuiInlineEdit] CHANGELOG & Copy Linting #6788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30bd1f9
Changelog & text linting from changes made in Github UI
breehall May 18, 2023
219c032
Snapshot update as a result of updating the copy of the aria-describe…
breehall May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src-docs/src/views/inline_edit/inline_edit_example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,10 @@ export const InlineEditExample = {
mode.
</p>
<p>
Return a boolean from your <EuiCode>onSave</EuiCode> callback to
validate text after pressing Save. You can also return a boolean from a
promise. Validation happens before the user returns to read mode.
Return a boolean from your <EuiCode>onSave</EuiCode> callback to
validate text after pressing Save. You can also return a boolean
from a promise. Validation happens before the user returns to read
mode.
</p>
<p>
Returning <EuiCode>false</EuiCode> from <EuiCode>onSave</EuiCode>{' '}
Expand Down
6 changes: 3 additions & 3 deletions src/components/inline_edit/__snapshots__/inline_edit_form.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ exports[`EuiInlineEditForm Read Mode readModeProps 1`] = `
hidden=""
id="inlineEdit_generated-id"
>
Click this button to edit this text inline.
Click to edit this text inline.
</span>
</div>
`;
Expand Down Expand Up @@ -706,7 +706,7 @@ exports[`EuiInlineEditForm Read Mode renders 1`] = `
hidden=""
id="inlineEdit_generated-id"
>
Click this button to edit this text inline.
Click to edit this text inline.
</span>
</div>
`;
Expand Down Expand Up @@ -740,7 +740,7 @@ exports[`EuiInlineEditForm Read Mode sizes 1`] = `
hidden=""
id="inlineEdit_generated-id"
>
Click this button to edit this text inline.
Click to edit this text inline.
</span>
</div>
`;
8 changes: 4 additions & 4 deletions src/components/inline_edit/__snapshots__/inline_edit_text.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ exports[`EuiInlineEditText renders 1`] = `
hidden=""
id="inlineEdit_generated-id"
>
Click this button to edit this text inline.
Click to edit this text inline.
</span>
</div>
`;
Expand Down Expand Up @@ -71,7 +71,7 @@ exports[`EuiInlineEditText text sizes renders m 1`] = `
hidden=""
id="inlineEdit_generated-id"
>
Click this button to edit this text inline.
Click to edit this text inline.
</span>
</div>
`;
Expand Down Expand Up @@ -109,7 +109,7 @@ exports[`EuiInlineEditText text sizes renders s 1`] = `
hidden=""
id="inlineEdit_generated-id"
>
Click this button to edit this text inline.
Click to edit this text inline.
</span>
</div>
`;
Expand Down Expand Up @@ -147,7 +147,7 @@ exports[`EuiInlineEditText text sizes renders xs 1`] = `
hidden=""
id="inlineEdit_generated-id"
>
Click this button to edit this text inline.
Click to edit this text inline.
</span>
</div>
`;
14 changes: 7 additions & 7 deletions src/components/inline_edit/__snapshots__/inline_edit_title.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ exports[`EuiInlineEditTitle renders 1`] = `
hidden=""
id="inlineEdit_generated-id"
>
Click this button to edit this text inline.
Click to edit this text inline.
</span>
</div>
`;
Expand Down Expand Up @@ -71,7 +71,7 @@ exports[`EuiInlineEditTitle title sizes renders size l 1`] = `
hidden=""
id="inlineEdit_generated-id"
>
Click this button to edit this text inline.
Click to edit this text inline.
</span>
</div>
`;
Expand Down Expand Up @@ -109,7 +109,7 @@ exports[`EuiInlineEditTitle title sizes renders size m 1`] = `
hidden=""
id="inlineEdit_generated-id"
>
Click this button to edit this text inline.
Click to edit this text inline.
</span>
</div>
`;
Expand Down Expand Up @@ -147,7 +147,7 @@ exports[`EuiInlineEditTitle title sizes renders size s 1`] = `
hidden=""
id="inlineEdit_generated-id"
>
Click this button to edit this text inline.
Click to edit this text inline.
</span>
</div>
`;
Expand Down Expand Up @@ -185,7 +185,7 @@ exports[`EuiInlineEditTitle title sizes renders size xs 1`] = `
hidden=""
id="inlineEdit_generated-id"
>
Click this button to edit this text inline.
Click to edit this text inline.
</span>
</div>
`;
Expand Down Expand Up @@ -223,7 +223,7 @@ exports[`EuiInlineEditTitle title sizes renders size xxs 1`] = `
hidden=""
id="inlineEdit_generated-id"
>
Click this button to edit this text inline.
Click to edit this text inline.
</span>
</div>
`;
Expand Down Expand Up @@ -261,7 +261,7 @@ exports[`EuiInlineEditTitle title sizes renders size xxxs 1`] = `
hidden=""
id="inlineEdit_generated-id"
>
Click this button to edit this text inline.
Click to edit this text inline.
</span>
</div>
`;
2 changes: 2 additions & 0 deletions upcoming_changelogs/6757.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Added `EuiInlineEditText` and `EuiInlineEditTitle` components