Skip to content

[EuiInlineEdit] Add onKeyDown Mapping for Saving and Canceling Edits #6742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
breehall merged 9 commits into from
May 2, 2023
Merged

[EuiInlineEdit] Add onKeyDown Mapping for Saving and Canceling Edits #6742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1d6c644
[EuiInlineEdit] Add keydown events that map the Enter and Escape keys…
breehall Apr 28, 2023
2460856
[REVERT ME] Added a custom keydown event that overrides our Enter map…
breehall Apr 28, 2023
192a6a7
[PR Feedback] Various structural updates including renaming test case…
breehall May 2, 2023
c48ee4f
[PR Feedback] Remove autoFocus from both the read mode button and edi…
breehall May 2, 2023
be36a75
Add aria-describedby property to the edit mode input
breehall May 2, 2023
b7b5646
Revert commit c48ee4f057c5a6f65a213a677f88644f62086874.
breehall May 2, 2023
e69ca86
Revert 2460856
breehall May 2, 2023
9eacae4
Pull aria-describedby outside of the edit mode input form row
breehall May 2, 2023
ea93bbd
Update test case to validate that custom onKeyDown events work along …
breehall May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions src/components/inline_edit/__snapshots__/inline_edit_form.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ exports[`EuiInlineEditForm Edit Mode editModeProps.cancelButtonProps 1`] = `
class="euiFormControlLayout__childrenWrapper"
>
<input
aria-describedby="inlineEdit_generated-id"
aria-label="Edit inline"
class="euiFieldText euiFieldText--fullWidth"
data-test-subj="euiInlineEditModeInput"
Expand All @@ -38,6 +39,12 @@ exports[`EuiInlineEditForm Edit Mode editModeProps.cancelButtonProps 1`] = `
</div>
</div>
</div>
<span
hidden=""
id="inlineEdit_generated-id"
>
Press Enter to save your edited text. Press Escape to cancel your edit.
</span>
</div>
<div
class="euiFlexItem euiInlineEdit testClass1 testClass2 emotion-euiFlexItem-growZero"
Expand Down Expand Up @@ -169,6 +176,7 @@ exports[`EuiInlineEditForm Edit Mode editModeProps.formRowProps 1`] = `
class="euiFormControlLayout__childrenWrapper"
>
<input
aria-describedby="inlineEdit_generated-id"
aria-label="Edit inline"
class="euiFieldText euiFieldText--fullWidth"
data-test-subj="euiInlineEditModeInput"
Expand All @@ -180,6 +188,12 @@ exports[`EuiInlineEditForm Edit Mode editModeProps.formRowProps 1`] = `
</div>
</div>
</div>
<span
hidden=""
id="inlineEdit_generated-id"
>
Press Enter to save your edited text. Press Escape to cancel your edit.
</span>
</div>
<div
class="euiFlexItem euiInlineEdit testClass1 testClass2 emotion-euiFlexItem-growZero"
Expand Down Expand Up @@ -315,6 +329,7 @@ exports[`EuiInlineEditForm Edit Mode editModeProps.inputProps 1`] = `
class="euiFormControlLayout__childrenWrapper"
>
<input
aria-describedby="inlineEdit_generated-id"
aria-label="Edit inline"
class="euiFieldText euiFieldText--fullWidth euiFieldText--inGroup"
data-test-subj="customInput"
Expand All @@ -326,6 +341,12 @@ exports[`EuiInlineEditForm Edit Mode editModeProps.inputProps 1`] = `
</div>
</div>
</div>
<span
hidden=""
id="inlineEdit_generated-id"
>
Press Enter to save your edited text. Press Escape to cancel your edit.
</span>
</div>
<div
class="euiFlexItem euiInlineEdit testClass1 testClass2 emotion-euiFlexItem-growZero"
Expand Down Expand Up @@ -455,6 +476,7 @@ exports[`EuiInlineEditForm Edit Mode editModeProps.saveButtonProps 1`] = `
class="euiFormControlLayout__childrenWrapper"
>
<input
aria-describedby="inlineEdit_generated-id"
aria-label="Edit inline"
class="euiFieldText euiFieldText--fullWidth"
data-test-subj="euiInlineEditModeInput"
Expand All @@ -466,6 +488,12 @@ exports[`EuiInlineEditForm Edit Mode editModeProps.saveButtonProps 1`] = `
</div>
</div>
</div>
<span
hidden=""
id="inlineEdit_generated-id"
>
Press Enter to save your edited text. Press Escape to cancel your edit.
</span>
</div>
<div
class="euiFlexItem euiInlineEdit testClass1 testClass2 emotion-euiFlexItem-growZero"
Expand Down Expand Up @@ -595,6 +623,7 @@ exports[`EuiInlineEditForm Edit Mode isInvalid 1`] = `
class="euiFormControlLayout__childrenWrapper"
>
<input
aria-describedby="inlineEdit_generated-id"
aria-invalid="true"
aria-label="Edit inline"
class="euiFieldText euiFormControlLayout--1icons euiFieldText--fullWidth"
Expand All @@ -615,6 +644,12 @@ exports[`EuiInlineEditForm Edit Mode isInvalid 1`] = `
</div>
</div>
</div>
<span
hidden=""
id="inlineEdit_generated-id"
>
Press Enter to save your edited text. Press Escape to cancel your edit.
</span>
</div>
<div
class="euiFlexItem euiInlineEdit testClass1 testClass2 emotion-euiFlexItem-growZero"
Expand Down Expand Up @@ -744,6 +779,7 @@ exports[`EuiInlineEditForm Edit Mode isLoading 1`] = `
class="euiFormControlLayout__childrenWrapper"
>
<input
aria-describedby="inlineEdit_generated-id"
aria-label="Edit inline"
class="euiFieldText euiFormControlLayout--1icons euiFieldText--fullWidth euiFieldText-isLoading"
data-test-subj="euiInlineEditModeInput"
Expand All @@ -764,6 +800,12 @@ exports[`EuiInlineEditForm Edit Mode isLoading 1`] = `
</div>
</div>
</div>
<span
hidden=""
id="inlineEdit_generated-id"
>
Press Enter to save your edited text. Press Escape to cancel your edit.
</span>
</div>
<div
class="euiFlexItem euiInlineEdit testClass1 testClass2 emotion-euiFlexItem-growZero"
Expand Down Expand Up @@ -847,6 +889,7 @@ exports[`EuiInlineEditForm Edit Mode renders 1`] = `
class="euiFormControlLayout__childrenWrapper"
>
<input
aria-describedby="inlineEdit_generated-id"
aria-label="Edit inline"
class="euiFieldText euiFieldText--fullWidth"
data-test-subj="euiInlineEditModeInput"
Expand All @@ -858,6 +901,12 @@ exports[`EuiInlineEditForm Edit Mode renders 1`] = `
</div>
</div>
</div>
<span
hidden=""
id="inlineEdit_generated-id"
>
Press Enter to save your edited text. Press Escape to cancel your edit.
</span>
</div>
<div
class="euiFlexItem euiInlineEdit testClass1 testClass2 emotion-euiFlexItem-growZero"
Expand Down
64 changes: 64 additions & 0 deletions src/components/inline_edit/inline_edit_form.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,5 +333,69 @@ describe('EuiInlineEditForm', () => {
});
});
});

describe('keyboard events', () => {
test('pressing the Enter key saves text and returns to readMode', () => {
const { getByTestSubject, getByText } = render(
<EuiInlineEditForm
{...commonInlineEditFormProps}
startWithEditOpen={true}
/>
);

fireEvent.change(getByTestSubject('euiInlineEditModeInput'), {
target: { value: 'New message!' },
});
fireEvent.keyDown(getByTestSubject('euiInlineEditModeInput'), {
key: 'Enter',
});

expect(getByTestSubject('euiInlineReadModeButton')).toBeTruthy();
expect(getByText('New message!')).toBeTruthy();
});

test('pressing the Escape key cancels text changes and returns to readMode', () => {
const { getByTestSubject, getByText } = render(
<EuiInlineEditForm
{...commonInlineEditFormProps}
startWithEditOpen={true}
/>
);

fireEvent.change(getByTestSubject('euiInlineEditModeInput'), {
target: { value: 'New message!' },
});
fireEvent.keyDown(getByTestSubject('euiInlineEditModeInput'), {
key: 'Escape',
});

expect(getByTestSubject('euiInlineReadModeButton')).toBeTruthy();
expect(getByText('Hello World!')).toBeTruthy();
});

it('calls passed `inputModeProps.onKeyDown` callbacks', () => {
const onKeyDown = jest.fn();

const { getByTestSubject, getByText } = render(
<EuiInlineEditForm
{...commonInlineEditFormProps}
startWithEditOpen={true}
editModeProps={{ inputProps: { onKeyDown } }}
/>
);

fireEvent.change(getByTestSubject('euiInlineEditModeInput'), {
target: { value: 'New message!' },
});
fireEvent.keyDown(getByTestSubject('euiInlineEditModeInput'), {
key: 'Enter',
});

// Both EUI and consumer `onKeyDown` events should have run
expect(onKeyDown).toHaveBeenCalled();
expect(getByTestSubject('euiInlineReadModeButton')).toBeTruthy();
expect(getByText('New message!')).toBeTruthy();
});
});
});
});
32 changes: 30 additions & 2 deletions src/components/inline_edit/inline_edit_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import React, {
useState,
HTMLAttributes,
MouseEvent,
KeyboardEvent,
} from 'react';
import classNames from 'classnames';

Expand All @@ -29,8 +30,8 @@ import { EuiButtonIconPropsForButton } from '../button/button_icon';
import { EuiButtonEmptyPropsForButton } from '../button/button_empty/button_empty';
import { EuiFlexGroup, EuiFlexItem } from '../flex';
import { EuiSkeletonRectangle } from '../skeleton';
import { useEuiTheme } from '../../services';
import { useEuiI18n } from '../i18n';
import { useEuiTheme, keys } from '../../services';
import { EuiI18n, useEuiI18n } from '../i18n';
import { useGeneratedHtmlId } from '../../services/accessibility';

// Props shared between the internal form component as well as consumer-facing components
Expand Down Expand Up @@ -139,6 +140,8 @@ export const EuiInlineEditForm: FunctionComponent<EuiInlineEditFormProps> = ({
'Cancel edit'
);

const editModeDescribedById = useGeneratedHtmlId({ prefix: 'inlineEdit' });

const [isEditing, setIsEditing] = useState(false || startWithEditOpen);
const inlineEditInputId = useGeneratedHtmlId({ prefix: '__inlineEditInput' });

Expand All @@ -163,6 +166,17 @@ export const EuiInlineEditForm: FunctionComponent<EuiInlineEditFormProps> = ({
setIsEditing(false);
};

const editModeInputOnKeyDown = (event: KeyboardEvent<HTMLElement>) => {
switch (event.key) {
case keys.ENTER:
saveInlineEditValue();
break;
case keys.ESCAPE:
cancelInlineEdit();
break;
}
};

const editModeForm = (
<EuiForm fullWidth>
<EuiFlexGroup gutterSize="s">
Expand All @@ -185,8 +199,22 @@ export const EuiInlineEditForm: FunctionComponent<EuiInlineEditFormProps> = ({
isLoading={isLoading}
data-test-subj="euiInlineEditModeInput"
{...editModeProps?.inputProps}
aria-describedby={classNames(
editModeDescribedById,
editModeProps?.inputProps?.['aria-describedby']
)}
onKeyDown={(e: KeyboardEvent<HTMLInputElement>) => {
editModeInputOnKeyDown(e);
editModeProps?.inputProps?.onKeyDown?.(e);
}}
/>
</EuiFormRow>
<span id={editModeDescribedById} hidden>
<EuiI18n
token="euiInlineEditForm.inputKeyboardInstructions"
default="Press Enter to save your edited text. Press Escape to cancel your edit."
/>
</span>
</EuiFlexItem>

<EuiFlexItem grow={false} className={classes}>
Expand Down