-
Notifications
You must be signed in to change notification settings - Fork 860
[EuiInlineEdit] Create EuiInlineEdit Docs
#6697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
breehall
merged 6 commits into
elastic:feature/EuiInlineEdit
from
breehall:inline-edit/docs
Apr 11, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e613491
Export the EuiInlineEdit Text and Title prop types
breehall 7b1f22e
Created docs examples for EuiInlineEdit props
breehall 15a78f8
Removed an export for EuiInlineEditTextSizes as devs can drill into T…
breehall 2d0975d
[PR Feedback] - Reorder sections of the EuiInlineEdit docs. Update th…
breehall d5c04f6
[Oops] Removed and replaced the EuiInlineEditTextSize import in Inlin…
breehall 387e9ea
Update src-docs/src/views/inline_edit/inline_edit_example.js
breehall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import React from 'react'; | ||
|
|
||
| import { EuiInlineEditText } from '../../../../src'; | ||
|
|
||
| export default () => { | ||
| return ( | ||
| <EuiInlineEditText | ||
| inputAriaLabel="Edit text inline for readMode and editMode props" | ||
| defaultValue="This inline edit component has been customized!" | ||
| size="m" | ||
| readModeProps={{ color: 'primary', iconSide: 'left' }} | ||
| editModeProps={{ | ||
| inputProps: { | ||
| prepend: 'Prepend Example', | ||
| }, | ||
| }} | ||
| /> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about changing this line to the following?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my 2c: I don't feel super strongly either way about form control vs input, but we do clearly categorize and label our many form components as
form controls in EUI's documentation