Skip to content

Fix HTMLAttributes type incorrectly coming from enzyme #6643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cee-chen merged 3 commits into from
Mar 14, 2023
Merged

Fix HTMLAttributes type incorrectly coming from enzyme #6643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14b1042
Fix HTMLAttributes type incorrectly coming from `enzyme` instead of `…
cee-chen Mar 14, 2023
0627a25
Fix type
cee-chen Mar 14, 2023
d965934
changelog
cee-chen Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/components/page/page_content/page_content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,11 @@
* Side Public License, v 1.
*/

import React, { FunctionComponent } from 'react';
import React, { FunctionComponent, HTMLAttributes } from 'react';
import classNames from 'classnames';
import { CommonProps } from '../../common';

import { EuiPanel, _EuiPanelProps, _EuiPanelDivlike } from '../../panel/panel';
import { HTMLAttributes } from 'enzyme';

export type EuiPageContentVerticalPositions = 'center';
export type EuiPageContentHorizontalPositions = 'center';
Expand All @@ -38,7 +37,7 @@ export type EuiPageContentProps = CommonProps &
* There should only be one EuiPageContent per page and should contain the main contents.
* If this is untrue, set role = `null`, or change it to match your needed aria role
*/
role?: HTMLAttributes['role'] | null;
role?: HTMLAttributes<HTMLElement>['role'] | null;
};

/**
Expand Down
3 changes: 3 additions & 0 deletions upcoming_changelogs/6643.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed a type definition incorrectly coming from a dev dependency, which was causing issues for some consuming projects