Merged
Conversation
snide
added a commit
to snide/eui
that referenced
this pull request
Apr 11, 2018
snide
added a commit
that referenced
this pull request
Apr 11, 2018
weltenwort
reviewed
Apr 12, 2018
Member
weltenwort
left a comment
weltenwort
left a comment
There was a problem hiding this comment.
LGTM, just left a few small comments below.
|
|
||
| - Visual fix for the focus state of disabled `EuiButton` ([#603](https://github.com/elastic/eui/pull/603)) | ||
| - `EuiSelect` can pass any node as a value rather than just a string ([#603](https://github.com/elastic/eui/pull/603)) | ||
| - Visually fixed for the focus state of disabled `EuiButton` ([#603](https://github.com/elastic/eui/pull/603)) |
Member
There was a problem hiding this comment.
That doesn't sound right anymore - how about
- Fixed the focus state styling of disabled
EuiButtons (#603)
?
| **Breaking changes** | ||
|
|
||
| - Support values on radio inputs. This is breaking because now the second argument to the radio `onChange` callback is the value, which bumps the change event to the third argument ([#613](https://github.com/elastic/eui/pull/613)) | ||
| - Supported values on radio inputs. This is breaking because now the second argument to the radio `onChange` callback is the value, which bumps the change event to the third argument ([#613](https://github.com/elastic/eui/pull/613)) |
Member
There was a problem hiding this comment.
How about
- Added support for values on radio inputs. [...]
?
| - `EuiInMemoryTable` passes items to `BasicTable` when `message` is provided ([#517](https://github.com/elastic/eui/pull/517)). | ||
| - `EuiSearchBox` now passes unused props through to `EuiFieldSearch` ([#514](https://github.com/elastic/eui/pull/514)) | ||
| - Change `EuiBasicTable` `noItemsMessage` and `EuiInMemoryTable` `messgae` propType to node | ||
| - Changed `EuiBasicTable` `noItemsMessage` and `EuiInMemoryTable` `messgae` propType to node |
Member
There was a problem hiding this comment.
I know the typo was not introduced in this PR, but the prop is probably called message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.