[EuiTour] Add extra spacing between the title and subtitle
#6512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6512/ |
1Copenut
approved these changes
Jan 5, 2023
Contributor
1Copenut
left a comment
1Copenut
left a comment
There was a problem hiding this comment.
LGTM! I pulled your branch locally to spot check and run an axe plugin scan.
cee-chen
added a commit
to elastic/kibana
that referenced
this pull request
Jan 13, 2023
## Summary `[email protected]` ⏩ `[email protected]` --- - Added `onFullScreen` callback to expose the `isFullScreen` state of the `EuiImage` ([#6504](elastic/eui#6504)) - Added an extra spacing between the title and subtitle to `EuiTour` ([#6512](elastic/eui#6512)) - Updated `EuiText.blockquote` styles to match the `EuiMarkdownFormat.blockquote` styles ([#6514](elastic/eui#6514)) - Added the `repositionOnScroll` prop to `EuiToolTip` ([#6515](elastic/eui#6515)) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Jason Stoltzfus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an extra spacing of 4px (
euiTheme.size.xs) between thetitleandsubtitlein EuiTour and closes #5848.QA
Remove or strikethrough items that do not apply to your PR.
General checklist