[EuiOverlayMask] Fix example with duplicate masks & misc cleanup #6290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- EuiFlyout now uses ownFocus / EuiOverlayMask by default so the current example is loading TWO overlay masks :| - update example to use a generic mask with `below` set and also show an EuiFlyout example as normal
- remove unnecessary explicit fragments and fn wrappers
cee-chen
added
the
skip-changelog
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6290/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed while working on #6289 that the 2nd example was rendering two EuiOverlayMasks 🙃 https://eui.elastic.co/v69.0.0/#/utilities/overlay-mask#masks-with-header
This appears to be because we modified
EuiFlyoutat some point to default to showing a mask and also setting that mask tobelow.Checklist
N/A, docs only