Skip to content

[EuiIcon] Correct isMounted logic #6166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2022
Merged

[EuiIcon] Correct isMounted logic #6166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d44dc56
Correct EuiIcon's isMounted logic
chandlerprall Aug 23, 2022
1a6dffc
changelog
chandlerprall Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/icon/icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ export class EuiIconClass extends PureComponent<
EuiIconProps & WithEuiThemeProps,
State
> {
isMounted = true;
isMounted = false;
constructor(props: EuiIconProps & WithEuiThemeProps) {
super(props);

Expand All @@ -149,6 +149,7 @@ export class EuiIconClass extends PureComponent<
}

componentDidMount() {
this.isMounted = true;
const { type } = this.props;

if (isEuiIconType(type) && this.state.icon == null) {
Expand Down
3 changes: 3 additions & 0 deletions upcoming_changelogs/6166.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed a bug in some development environments which prevented `EuiIcon` from loading icons asynchronously