Skip to content

[EuiAccordion] Fix resize observer loop error when drag&dropping an accordion #6031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chandlerprall merged 6 commits into from
Jul 6, 2022
Merged

[EuiAccordion] Fix resize observer loop error when drag&dropping an accordion #6031

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5bff3ca
Prevent accordion renders from re-instantiating resize observers by o…
chandlerprall Jul 6, 2022
fa3f198
revert me
chandlerprall Jul 6, 2022
0e8b011
changelog
chandlerprall Jul 6, 2022
a9f8af8
changelog (2)
chandlerprall Jul 6, 2022
b1b7dd1
Update src/components/accordion/accordion.tsx
chandlerprall Jul 6, 2022
627b87f
Revert "revert me"
chandlerprall Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 104 additions & 18 deletions src-docs/src/views/drag_and_drop/drag_and_drop_custom_handle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@ import {
EuiDragDropContext,
EuiDraggable,
EuiDroppable,
EuiFlexGroup,
EuiFlexItem,
EuiIcon,
EuiPanel,
euiDragDropReorder,
EuiAccordion,
EuiButtonIcon,
} from '../../../../src/components';
import { htmlIdGenerator } from '../../../../src/services';

Expand All @@ -21,7 +20,7 @@ const makeList = (number, start = 1) =>
};
});

export default () => {
export const Demo = () => {
const [list, setList] = useState(makeList(3));
const onDragEnd = ({ source, destination }) => {
if (source && destination) {
Expand All @@ -37,30 +36,56 @@ export default () => {
spacing="m"
withPanel
>
{list.map(({ content, id }, idx) => (
{list.map(({ id }, idx) => (
<EuiDraggable
spacing="m"
key={id}
index={idx}
draggableId={id}
customDragHandle={true}
hasInteractiveChildren={true}
disableInteractiveElementBlocking
>
{(provided) => (
<EuiPanel paddingSize="s">
<EuiFlexGroup alignItems="center" gutterSize="s">
<EuiFlexItem grow={false}>
<EuiPanel
color="transparent"
paddingSize="s"
<EuiAccordion
id={id}
initialIsOpen={false}
buttonContent={<>Button</>}
extraAction={[
<EuiButtonIcon
key={1}
iconType="grab"
color={'text'}
{...provided.dragHandleProps}
aria-label="Drag Handle"
>
<EuiIcon type="grab" />
</EuiPanel>
</EuiFlexItem>
<EuiFlexItem>{content}</EuiFlexItem>
</EuiFlexGroup>
aria-label="fsdfsdfsd"
/>,
]}
>
dsfds fsd
<br />
dsfds fsd
<br />
dsfds fsd
<br />
dsfds fsd
<br />
dsfds fsd
<br />
dsfds fsd
<br />
dsfds fsd
<br />
dsfds fsd
<br />
dsfds fsd
<br />
dsfds fsd
<br />
dsfds fsd
<br />
dsfds fsd
<br />
</EuiAccordion>
</EuiPanel>
)}
</EuiDraggable>
Expand All @@ -69,3 +94,64 @@ export default () => {
</EuiDragDropContext>
);
};

export default Demo;

// const makeId = htmlIdGenerator();
//
// const makeList = (number, start = 1) =>
// Array.from({ length: number }, (v, k) => k + start).map((el) => {
// return {
// content: `Item ${el}`,
// id: makeId(),
// };
// });
//
// export default () => {
// const [list, setList] = useState(makeList(3));
// const onDragEnd = ({ source, destination }) => {
// if (source && destination) {
// const items = euiDragDropReorder(list, source.index, destination.index);
//
// setList(items);
// }
// };
// return (
// <EuiDragDropContext onDragEnd={onDragEnd}>
// <EuiDroppable
// droppableId="CUSTOM_HANDLE_DROPPABLE_AREA"
// spacing="m"
// withPanel
// >
// {list.map(({ content, id }, idx) => (
// <EuiDraggable
// spacing="m"
// key={id}
// index={idx}
// draggableId={id}
// customDragHandle={true}
// hasInteractiveChildren={true}
// >
// {(provided) => (
// <EuiPanel paddingSize="s">
// <EuiFlexGroup alignItems="center" gutterSize="s">
// <EuiFlexItem grow={false}>
// <EuiPanel
// color="transparent"
// paddingSize="s"
// {...provided.dragHandleProps}
// aria-label="Drag Handle"
// >
// <EuiIcon type="grab" />
// </EuiPanel>
// </EuiFlexItem>
// <EuiFlexItem>{content}</EuiFlexItem>
// </EuiFlexGroup>
// </EuiPanel>
// )}
// </EuiDraggable>
// ))}
// </EuiDroppable>
// </EuiDragDropContext>
// );
// };
Loading