Skip to content

[DataGrid] Ensure referential integrity of focused cell #6007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kerry350 merged 9 commits into from
Jul 4, 2022
+31 −9
Merged

[DataGrid] Ensure referential integrity of focused cell #6007

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eea26f9
Ensure focused cell is only updated with new values
Kerry350 Jun 28, 2022
30c5776
Add unit test to confirm focusedCell memory equality does not change
cee-chen Jun 29, 2022
29ab7c9
Merge remote-tracking branch 'upstream/main' into data-grid-focused-cell
Kerry350 Jun 30, 2022
29fb717
Add changelog entry
Kerry350 Jun 30, 2022
6df1008
Merge branch 'data-grid-focused-cell' of github.com:Kerry350/eui into…
Kerry350 Jun 30, 2022
f8ab655
Update src/components/datagrid/utils/focus.ts
Kerry350 Jun 30, 2022
f704461
Merge branch 'data-grid-focused-cell' of github.com:Kerry350/eui into…
Kerry350 Jun 30, 2022
5992d44
Expand comment slightly
Kerry350 Jun 30, 2022
e2146c8
Changelog formatting
constancecchen Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/components/datagrid/utils/focus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,21 @@ export const useFocus = ({
EuiDataGridFocusedCell | undefined
>(undefined);

const setFocusedCell = useCallback((focusedCell: EuiDataGridFocusedCell) => {
_setFocusedCell(focusedCell);
setIsFocusedCellInView(true); // scrolling.ts ensures focused cells are fully in view
}, []);
const setFocusedCell = useCallback(
(nextFocusedCell: EuiDataGridFocusedCell) => {
if (
focusedCell &&
nextFocusedCell[0] === focusedCell[0] &&
nextFocusedCell[1] === focusedCell[1]
) {
return;
}
Comment thread
Kerry350 marked this conversation as resolved.

_setFocusedCell(nextFocusedCell);
setIsFocusedCellInView(true); // scrolling.ts ensures focused cells are fully in view
},
[focusedCell]
);

const previousCell = useRef<EuiDataGridFocusedCell | undefined>(undefined);
useEffect(() => {
Expand Down