Skip to content

[EuiIcon] Add k8s icons #6001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elizabetdev merged 5 commits into from
Jun 30, 2022
Merged

[EuiIcon] Add k8s icons #6001

elizabetdev merged 5 commits into from
Jun 30, 2022

Conversation

@elizabetdev
Copy link
Contributor

@elizabetdev elizabetdev commented Jun 27, 2022 •
edited
Loading

Summary

Closes #5993.

This PR adds cluster, container, kubernetesNode, kubernetesPod and namespace glyphs to EuiIcon. These icons are meant to be used in Security (new page for Kubernetes infrastructure).

Icons preview

The icons can be found here: https://eui.elastic.co/pr_6001/#/display/icons

Design

Screenshot 2022-06-28 at 20 00 31

Light and dark mode

preview-light-dark-before@2x

Checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@elizabetdev elizabetdev added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Jun 27, 2022
@kibanamachine
Copy link

kibanamachine commented Jun 27, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6001/

@elizabetdev elizabetdev mentioned this pull request Jun 27, 2022
Closed
@elizabetdev elizabetdev changed the title Added k8sicons [EuiIcon] Add k8s icons Jun 27, 2022
@kibanamachine
Copy link

kibanamachine commented Jun 27, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6001/

@kibanamachine
Copy link

kibanamachine commented Jun 28, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6001/

@elizabetdev elizabetdev removed the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Jun 28, 2022
@kibanamachine
Copy link

kibanamachine commented Jun 28, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6001/

@elizabetdev elizabetdev marked this pull request as ready for review June 28, 2022 19:01
opauloh
opauloh approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🚀

codearos
codearos approved these changes Jun 29, 2022
View reviewed changes
Copy link

@codearos codearos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good for me.

@Max-Iskra Max-Iskra self-requested a review June 29, 2022 14:09
@elizabetdev
Copy link
Contributor Author

elizabetdev commented Jun 30, 2022

Hi, @Max-Iskra are you going to review this PR? Is it ok if I merge it?

Max-Iskra
Max-Iskra approved these changes Jun 30, 2022
View reviewed changes
Copy link

@Max-Iskra Max-Iskra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good for me, thank you!

@elizabetdev elizabetdev enabled auto-merge (squash) June 30, 2022 18:43
@kibanamachine
Copy link

kibanamachine commented Jun 30, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6001/

@elizabetdev elizabetdev merged commit 4f6e1ae into elastic:main Jun 30, 2022
@breehall breehall mentioned this pull request Jul 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cchaos cchaos Awaiting requested review from cchaos

3 more reviewers

@opauloh opauloh opauloh approved these changes

@codearos codearos codearos approved these changes

@Max-Iskra Max-Iskra Max-Iskra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New Icons for kubernetes page (Security)

5 participants

@elizabetdev @kibanamachine @opauloh @codearos @Max-Iskra