Skip to content

Add more unit tests to the header component #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snide merged 1 commit into from
Mar 30, 2018
Merged

Add more unit tests to the header component #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/components/header/__snapshots__/header.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,13 @@ exports[`EuiHeader is rendered 1`] = `
data-test-subj="test subject string"
/>
`;

exports[`EuiHeader renders children 1`] = `
<div
class="euiHeader"
>
<span>
Hello!
</span>
</div>
`;
27 changes: 27 additions & 0 deletions src/components/header/__snapshots__/header_logo.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,30 @@ exports[`EuiHeaderLogo renders href 1`] = `
</svg>
</a>
`;

exports[`EuiHeaderLogo renders optional props 1`] = `
<a
class="euiHeaderLogo"
style="color:red"
>
<svg
class="euiIcon euiHeaderLogo__icon euiIcon--xLarge"
height="16"
title="Moby Dick"
viewBox="0 0 16 16"
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<g
fill-rule="evenodd"
>
<path
d="M7.5 2.236L1.618 14h11.764L7.5 2.236zm.894-.447l5.882 11.764A1 1 0 0 1 13.382 15H1.618a1 1 0 0 1-.894-1.447L6.606 1.789a1 1 0 0 1 1.788 0z"
/>
<path
d="M7 6h1v5H7zM7 12h1v1H7z"
/>
</g>
</svg>
</a>
`;
11 changes: 11 additions & 0 deletions src/components/header/header.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,15 @@ describe('EuiHeader', () => {
expect(component)
.toMatchSnapshot();
});

test('renders children', () => {
const component = render(
<EuiHeader>
<span>Hello!</span>
</EuiHeader>
);

expect(component)
.toMatchSnapshot();
});
});
203 changes: 200 additions & 3 deletions src/components/header/header_alert/__snapshots__/header_alert.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,209 @@ exports[`EuiHeaderAlert is rendered 1`] = `
/>
</svg>
</button>
<p
<div
class="euiHeaderAlert__title"
>
title
</div>
<div
class="euiHeaderAlert__text"
/>
<div
class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--responsive"
>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
>
<div
class="euiHeaderAlert__action euiLink"
/>
</div>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
>
<div
class="euiHeaderAlert__date"
>
date
</div>
</div>
</div>
</div>
`;

exports[`EuiHeaderAlert renders action 1`] = `
<div
aria-label="aria-label"
class="euiHeaderAlert testClass1 testClass2"
data-test-subj="test subject string"
>
<button
aria-label="Dismiss"
class="euiButtonIcon euiButtonIcon--primary euiHeaderAlert__dismiss"
type="button"
>
<svg
aria-hidden="true"
class="euiIcon euiButtonIcon__icon euiIcon--medium"
height="16"
viewBox="0 0 16 16"
width="16"
xlink="http://www.w3.org/1999/xlink"
xmlns="http://www.w3.org/2000/svg"
>
<defs>
<path
d="M7.293 8l-4.147 4.146a.5.5 0 0 0 .708.708L8 8.707l4.146 4.147a.5.5 0 0 0 .708-.708L8.707 8l4.147-4.146a.5.5 0 0 0-.708-.708L8 7.293 3.854 3.146a.5.5 0 1 0-.708.708L7.293 8z"
id="cross-a"
/>
</defs>
<use
fill-rule="nonzero"
href="#cross-a"
/>
</svg>
</button>
<div
class="euiHeaderAlert__title"
>
title
</p>
<p
</div>
<div
class="euiHeaderAlert__text"
/>
<div
class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--responsive"
>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
>
<div
class="euiHeaderAlert__action euiLink"
>
<button>
Quietly take to the ship
</button>
</div>
</div>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
>
<div
class="euiHeaderAlert__date"
>
date
</div>
</div>
</div>
</div>
`;

exports[`EuiHeaderAlert renders date as an element 1`] = `
<div
aria-label="aria-label"
class="euiHeaderAlert testClass1 testClass2"
data-test-subj="test subject string"
>
<button
aria-label="Dismiss"
class="euiButtonIcon euiButtonIcon--primary euiHeaderAlert__dismiss"
type="button"
>
<svg
aria-hidden="true"
class="euiIcon euiButtonIcon__icon euiIcon--medium"
height="16"
viewBox="0 0 16 16"
width="16"
xlink="http://www.w3.org/1999/xlink"
xmlns="http://www.w3.org/2000/svg"
>
<defs>
<path
d="M7.293 8l-4.147 4.146a.5.5 0 0 0 .708.708L8 8.707l4.146 4.147a.5.5 0 0 0 .708-.708L8.707 8l4.147-4.146a.5.5 0 0 0-.708-.708L8 7.293 3.854 3.146a.5.5 0 1 0-.708.708L7.293 8z"
id="cross-a"
/>
</defs>
<use
fill-rule="nonzero"
href="#cross-a"
/>
</svg>
</button>
<div
class="euiHeaderAlert__title"
>
shazm
</div>
<div
class="euiHeaderAlert__text"
/>
<div
class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--responsive"
>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
>
<div
class="euiHeaderAlert__action euiLink"
/>
</div>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
>
<div
class="euiHeaderAlert__date"
>
<h2>
October 18, 1851
</h2>
</div>
</div>
</div>
</div>
`;

exports[`EuiHeaderAlert renders title as an element 1`] = `
<div
aria-label="aria-label"
class="euiHeaderAlert testClass1 testClass2"
data-test-subj="test subject string"
>
<button
aria-label="Dismiss"
class="euiButtonIcon euiButtonIcon--primary euiHeaderAlert__dismiss"
type="button"
>
<svg
aria-hidden="true"
class="euiIcon euiButtonIcon__icon euiIcon--medium"
height="16"
viewBox="0 0 16 16"
width="16"
xlink="http://www.w3.org/1999/xlink"
xmlns="http://www.w3.org/2000/svg"
>
<defs>
<path
d="M7.293 8l-4.147 4.146a.5.5 0 0 0 .708.708L8 8.707l4.146 4.147a.5.5 0 0 0 .708-.708L8.707 8l4.147-4.146a.5.5 0 0 0-.708-.708L8 7.293 3.854 3.146a.5.5 0 1 0-.708.708L7.293 8z"
id="cross-a"
/>
</defs>
<use
fill-rule="nonzero"
href="#cross-a"
/>
</svg>
</button>
<div
class="euiHeaderAlert__title"
>
<h2>
Circumambulate the city
</h2>
</div>
<div
class="euiHeaderAlert__text"
/>
<div
Expand Down
5 changes: 2 additions & 3 deletions src/components/header/header_alert/header_alert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ export const EuiHeaderAlert = ({
className="euiHeaderAlert__dismiss"
/>

<p className="euiHeaderAlert__title">{title}</p>
<div className="euiHeaderAlert__title">{title}</div>

<p className="euiHeaderAlert__text">{text}</p>
<div className="euiHeaderAlert__text">{text}</div>

<EuiFlexGroup justifyContent="spaceBetween">
<EuiFlexItem grow={false}>
Expand All @@ -54,7 +54,6 @@ export const EuiHeaderAlert = ({

EuiHeaderAlert.propTypes = {
action: PropTypes.node,
children: PropTypes.node,
className: PropTypes.string,
date: PropTypes.node.isRequired,
text: PropTypes.node,
Expand Down
49 changes: 49 additions & 0 deletions src/components/header/header_alert/header_alert.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,53 @@ describe('EuiHeaderAlert', () => {
expect(component)
.toMatchSnapshot();
});

test('renders action', () => {
const action = (
<button>Quietly take to the ship</button>
);
const component = render(
<EuiHeaderAlert
{...requiredProps}
title="title"
date="date"
action={action}
/>
);

expect(component)
.toMatchSnapshot();
});

test('renders title as an element', () => {
const title = (
<h2>Circumambulate the city</h2>
);
const component = render(
<EuiHeaderAlert
{...requiredProps}
date="date"
title={title}
/>
);

expect(component)
.toMatchSnapshot();
});

test('renders date as an element', () => {
const date = (
<h2>October 18, 1851</h2>
);
const component = render(
<EuiHeaderAlert
{...requiredProps}
title="shazm"
date={date}
/>
);

expect(component)
.toMatchSnapshot();
});
});
6 changes: 5 additions & 1 deletion src/components/header/header_breadcrumbs/__snapshots__/header_breadcrumbs.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,9 @@ exports[`EuiHeaderBreadcrumbs is rendered 1`] = `
aria-label="aria-label"
class="euiHeaderBreadcrumbs testClass1 testClass2"
data-test-subj="test subject string"
/>
>
<span>
I thought I would sail about a little and see the watery part of the world.
Copy link
Contributor

@snide snide Mar 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

</span>
</div>
`;
6 changes: 5 additions & 1 deletion src/components/header/header_breadcrumbs/header_breadcrumbs.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ import { EuiHeaderBreadcrumbs } from './header_breadcrumbs';
describe('EuiHeaderBreadcrumbs', () => {
test('is rendered', () => {
const component = render(
<EuiHeaderBreadcrumbs {...requiredProps} />
<EuiHeaderBreadcrumbs {...requiredProps}>
<span>
I thought I would sail about a little and see the watery part of the world.
</span>
</EuiHeaderBreadcrumbs>
);

expect(component)
Expand Down
13 changes: 13 additions & 0 deletions src/components/header/header_logo.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,17 @@ describe('EuiHeaderLogo', () => {
expect(component)
.toMatchSnapshot();
});

test('renders optional props', () => {
const component = render(
<EuiHeaderLogo
iconType="alert"
iconTitle="Moby Dick"
style={{ color: 'red' }}
/>
);

expect(component)
.toMatchSnapshot();
});
});
Loading