Skip to content

[EuiSpacer] Converts EuiSpacer to Emotion #5812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 20, 2022
Merged

[EuiSpacer] Converts EuiSpacer to Emotion #5812

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
173bb89
Converts spacer to Emotion
Apr 19, 2022
3ee3375
fix medium size to base size, add cl
Apr 19, 2022
01f59b9
snap snap
Apr 19, 2022
8f3a14d
snap snap
Apr 19, 2022
05f4d1c
Remove downstream mounted snapshots
cee-chen Apr 19, 2022
a9b8836
Fixed docs
Apr 19, 2022
bb4273e
Merge remote-tracking branch 'upstream/main' into emotion_spacer
cee-chen Apr 19, 2022
8f5b878
Add custom styles test
cee-chen Apr 19, 2022
5781933
wiki context for theming
Apr 20, 2022
473e1c4
Update upcoming_changelogs/5812.md
snide Apr 20, 2022
aea9142
Update wiki/consuming.md
snide Apr 20, 2022
de7f9c0
Update wiki/consuming.md
snide Apr 20, 2022
3b4a83a
Update wiki/consuming.md
snide Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
971 changes: 219 additions & 752 deletions src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/components/basic_table/in_memory_table.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,7 +985,7 @@ describe('EuiInMemoryTable', () => {
// this is specifically testing regression against https://github.com/elastic/eui/issues/1007
component.setProps({});

expect(component).toMatchSnapshot();
expect(component.render()).toMatchSnapshot();
});

test('pagination with actions column and sorting set to true', async () => {
Expand Down
8 changes: 4 additions & 4 deletions src/components/empty_prompt/__snapshots__/empty_prompt.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ exports[`EuiEmptyPrompt is rendered 1`] = `
class="euiTextColor euiTextColor--subdued"
>
<div
class="euiSpacer euiSpacer--m"
class="euiSpacer euiSpacer--m css-hg1jdf-euiSpacer-m"
/>
<div
class="euiText euiText--medium"
Expand All @@ -43,7 +43,7 @@ exports[`EuiEmptyPrompt is rendered 1`] = `
</div>
</span>
<div
class="euiSpacer euiSpacer--l"
class="euiSpacer euiSpacer--l css-jz428s-euiSpacer-l"
/>
<div>
Actions
Expand All @@ -68,7 +68,7 @@ exports[`EuiEmptyPrompt props actions renders alone 1`] = `
class="euiEmptyPrompt__contentInner"
>
<div
class="euiSpacer euiSpacer--l"
class="euiSpacer euiSpacer--l css-jz428s-euiSpacer-l"
/>
actions
</div>
Expand All @@ -91,7 +91,7 @@ exports[`EuiEmptyPrompt props actions renders an array 1`] = `
class="euiEmptyPrompt__contentInner"
>
<div
class="euiSpacer euiSpacer--l"
class="euiSpacer euiSpacer--l css-jz428s-euiSpacer-l"
/>
<div
class="euiFlexGroup euiFlexGroup--gutterMedium euiFlexGroup--alignItemsCenter euiFlexGroup--justifyContentCenter euiFlexGroup--directionColumn euiFlexGroup--responsive euiEmptyPrompt__actions"
Expand Down
3 changes: 1 addition & 2 deletions src/components/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
@import 'tree_view/index';
@import 'resizable_container/index';
@import 'side_nav/index';
@import 'spacer/index';
@import 'search_bar/index';
@import 'selectable/index';
@import 'stat/index';
Expand All @@ -66,4 +65,4 @@
@import 'token/index';
@import 'tool_tip/index';
@import 'tour/index';
@import 'text/index';
@import 'text/index';
Loading