Skip to content

[A11y] Added aria-label to the flyout testenv file #5702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuliacech merged 3 commits into from
Mar 9, 2022
Merged

[A11y] Added aria-label to the flyout testenv file #5702

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4846cc4
[A11y] Added `aria-label` to the flyout testenv
yuliacech Mar 9, 2022
9e18104
[A11y] Updated changelog
yuliacech Mar 9, 2022
26eeaaa
[A11y] Removed "no changes" line from the changelog
yuliacech Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
## [`main`](https://github.com/elastic/eui/tree/main)
- Updated `testenv` mock for `EuiFlyout` to include default `aria-label` on the close button ([#5702](https://github.com/elastic/eui/pull/5702))

No public interface changes since `51.0.0`.

@thompsongl thompsongl Mar 9, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Updated `testenv` mock for `EuiFlyout` to include default `aria-label` on the close button ([#5702](https://github.com/elastic/eui/pull/5702))
No public interface changes since `51.0.0`.
- Updated `testenv` mock for `EuiFlyout` to include default `aria-label` on the close button ([#5702](https://github.com/elastic/eui/pull/5702))


Expand Down
1 change: 1 addition & 0 deletions src/components/flyout/flyout.testenv.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export const EuiFlyout = ({
<button
type="button"
data-test-subj="euiFlyoutCloseButton"
aria-label="Close this dialog"
onClick={(e: React.MouseEvent<HTMLButtonElement>) => {
onClose();
closeButtonProps?.onClick && closeButtonProps.onClick(e);
Expand Down