Skip to content

[EuiFilePicker] Fix can still be cleared when disabled #5603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thompsongl merged 3 commits into from
Feb 4, 2022
Merged

[EuiFilePicker] Fix can still be cleared when disabled #5603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3c6864
Pass disabled prop down to buttons in EuiFilePicker
ayoung19 Feb 4, 2022
92181bf
Add EuiFilePicker bugfix to changelog
ayoung19 Feb 4, 2022
8e3eeb3
Don't display remove buttons at all when EuiFilePicker is disabled
ayoung19 Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
**Bug fixes**

- Fixed `EuiInMemoryTable`'s `onTableChange` callback not returning the correct `sort.field` value on pagination ([#5588](https://github.com/elastic/eui/pull/5588))
- Fixed `EuiFilePicker` allowing files to be removed when `disabled` ([#5603](https://github.com/elastic/eui/pull/5603))

## [`46.2.0`](https://github.com/elastic/eui/tree/v46.2.0)

Expand Down
2 changes: 1 addition & 1 deletion src/components/form/file_picker/file_picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ export class EuiFilePicker extends Component<EuiFilePickerProps> {
clearButton = (
<EuiLoadingSpinner className="euiFilePicker__loadingSpinner" />
);
} else if (isOverridingInitialPrompt) {
} else if (isOverridingInitialPrompt && !disabled) {
if (normalFormControl) {
clearButton = (
<button
Expand Down