Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
## [`main`](https://github.com/elastic/eui/tree/main)

**Bug fixes**

- Fixed a `EuiDataGrid` inconsistent color halo when focusing on the control columns by changing outline of class `euiButtonIcon` in `euiDataGridRowCell` and mixin `euiCustomControlFocused` [#5522](https://github.com/elastic/eui/pull/5522))
Comment thread
Al-0 marked this conversation as resolved.
Outdated

**Breaking changes**

- Changed `EuiSearchBar` to preserve phrases with leading and trailing spaces, instead of dropping surrounding whitespace ([#5514](https://github.com/elastic/eui/pull/5514))
Expand Down
7 changes: 7 additions & 0 deletions src/components/datagrid/_data_grid_data_row.scss
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,13 @@
white-space: nowrap;
}
}

// Ensures focus halo color consistency in ButtonIcons inside of the grid
.euiButtonIcon {
&:focus {
outline: $euiFocusRingColor solid $euiFocusRingSize;
}
}
}

.euiDataGridRowCell__popover {
Expand Down
3 changes: 2 additions & 1 deletion src/global_styling/mixins/_form.scss
Original file line number Diff line number Diff line change
Expand Up @@ -344,13 +344,14 @@
// Requires a selector to work with the Amsterdam outline styles
@if ($amsterdamSelector) {
+ #{$amsterdamSelector} {
outline: $euiFocusRingSize solid currentColor;
outline: $euiFocusRingColor solid $euiFocusRingSize;
Comment thread
Al-0 marked this conversation as resolved.
Outdated
}

// Chrome
&:focus-visible + #{$amsterdamSelector} {
outline-style: auto;
outline-offset: 3px;
outline: $euiFocusRingColor solid $euiFocusRingSize;
Comment thread
Al-0 marked this conversation as resolved.
Outdated
}

&:not(:focus-visible) + #{$amsterdamSelector} {
Expand Down