Skip to content

Refactoring EuiKeyPadMenuItem beta badge for improved accessibility #5508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1Copenut wants to merge 8 commits into from
Closed

Refactoring EuiKeyPadMenuItem beta badge for improved accessibility #5508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3258086
Refactoring EuiKeypadMenuItem beta badge for improved accessibility
Dec 28, 2021
c107d41
Adding a changelog entry for issue 5290.
Dec 28, 2021
8723f28
Refactoring CSS and adding JS guard check
Dec 29, 2021
1f09ad2
Refactoring ARIA label for localization.
Jan 4, 2022
6f679f3
Fixing a changelog conflict.
Jan 4, 2022
3744698
Refactoring to use a relatively positioned container.
Jan 11, 2022
ba06212
Refactoring for variable width parent, and fixed element width
Jan 12, 2022
a7d44b5
Removing unused variable and comments
Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Fixed a `EuiDataGrid` sizing bug which didn't account for a horizontal scrollbar ([#5478](https://github.com/elastic/eui/pull/5478))
- Fixed a `EuiDatePicker` a11y bug where axe-core reported missing ARIA and role attributes ([#5501](https://github.com/elastic/eui/pull/5501))
- Fixed `EuiModalHeaderTitle` to conditionally wrap title strings in an H1 ([#5494](https://github.com/elastic/eui/pull/5494))
- Fixed `EuiKeypadMenuItem` accessibility issue where there was a nested focusable element ([#5508](https://github.com/elastic/eui/pull/5508))
- Fixed a `EuiDataGrid` issue where a focused cell would lose focus when scrolled out of and back into view ([#5488](https://github.com/elastic/eui/pull/5488))
- Fixed an `EuiDatePicker` accessibility issue where `tabindex` was not applied to a listbox element ([#5509](https://github.com/elastic/eui/pull/5509))

Expand Down
2 changes: 1 addition & 1 deletion src/components/badge/beta_badge/beta_badge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ export const EuiBetaBadge: FunctionComponent<EuiBetaBadgeProps> = ({
content={tooltipContent}
title={title || label}
>
<span tabIndex={0} className={classes} {...rest}>
<span tabIndex={0} className={classes} role="button" {...rest}>
Copy link
Contributor Author

@1Copenut 1Copenut Dec 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this role="button" because Safari + VoiceOver wasn't consistently announcing the tooltip. Found this article Short note on aria-label, aria-labelledby, and aria-describedby by Leonie Watson that gave me a clue the span alone might not honor our ARIA markup consistently.

{icon || label}
</span>
</EuiToolTip>
Expand Down
12 changes: 6 additions & 6 deletions src/components/context_menu/__snapshots__/context_menu_panel.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ exports[`EuiContextMenuPanel props transitionDirection previous with transitionT

exports[`EuiContextMenuPanel updating items and content updates to items should not re-render if any items's watchedItemProps did not change 1`] = `
"<EuiContextMenuPanel items={{...}} hasFocus={true}>
<div className=\\"euiContextMenuPanel\\" onKeyDown={[Function (anonymous)]} tabIndex={-1} onAnimationEnd={[Function (anonymous)]}>
<div className=\\"euiContextMenuPanel\\" onKeyDown={[Function]} tabIndex={-1} onAnimationEnd={[Function]}>
<div>
<EuiResizeObserver onResize={[Function: onResize]}>
<div>
Expand Down Expand Up @@ -591,7 +591,7 @@ exports[`EuiContextMenuPanel updating items and content updates to items should

exports[`EuiContextMenuPanel updating items and content updates to items should not re-render if any items's watchedItemProps did not change 2`] = `
"<EuiContextMenuPanel items={{...}} hasFocus={true}>
<div className=\\"euiContextMenuPanel\\" onKeyDown={[Function (anonymous)]} tabIndex={-1} onAnimationEnd={[Function (anonymous)]}>
<div className=\\"euiContextMenuPanel\\" onKeyDown={[Function]} tabIndex={-1} onAnimationEnd={[Function]}>
<div>
<EuiResizeObserver onResize={[Function: onResize]}>
<div>
Expand Down Expand Up @@ -622,7 +622,7 @@ exports[`EuiContextMenuPanel updating items and content updates to items should

exports[`EuiContextMenuPanel updating items and content updates to items should re-render at all times when children exists 1`] = `
"<EuiContextMenuPanel hasFocus={true} items={{...}}>
<div className=\\"euiContextMenuPanel\\" onKeyDown={[Function (anonymous)]} tabIndex={-1} onAnimationEnd={[Function (anonymous)]}>
<div className=\\"euiContextMenuPanel\\" onKeyDown={[Function]} tabIndex={-1} onAnimationEnd={[Function]}>
<div>
<EuiResizeObserver onResize={[Function: onResize]}>
<div>
Expand All @@ -636,7 +636,7 @@ exports[`EuiContextMenuPanel updating items and content updates to items should

exports[`EuiContextMenuPanel updating items and content updates to items should re-render at all times when children exists 2`] = `
"<EuiContextMenuPanel hasFocus={true} items={{...}}>
<div className=\\"euiContextMenuPanel\\" onKeyDown={[Function (anonymous)]} tabIndex={-1} onAnimationEnd={[Function (anonymous)]}>
<div className=\\"euiContextMenuPanel\\" onKeyDown={[Function]} tabIndex={-1} onAnimationEnd={[Function]}>
<div>
<EuiResizeObserver onResize={[Function: onResize]}>
<div>
Expand All @@ -650,7 +650,7 @@ exports[`EuiContextMenuPanel updating items and content updates to items should

exports[`EuiContextMenuPanel updating items and content updates to items should re-render if any items's watchedItemProps did change 1`] = `
"<EuiContextMenuPanel watchedItemProps={{...}} items={{...}} hasFocus={true}>
<div className=\\"euiContextMenuPanel\\" onKeyDown={[Function (anonymous)]} tabIndex={-1} onAnimationEnd={[Function (anonymous)]}>
<div className=\\"euiContextMenuPanel\\" onKeyDown={[Function]} tabIndex={-1} onAnimationEnd={[Function]}>
<div>
<EuiResizeObserver onResize={[Function: onResize]}>
<div>
Expand Down Expand Up @@ -681,7 +681,7 @@ exports[`EuiContextMenuPanel updating items and content updates to items should

exports[`EuiContextMenuPanel updating items and content updates to items should re-render if any items's watchedItemProps did change 2`] = `
"<EuiContextMenuPanel watchedItemProps={{...}} items={{...}} hasFocus={true}>
<div className=\\"euiContextMenuPanel\\" onKeyDown={[Function (anonymous)]} tabIndex={-1} onAnimationEnd={[Function (anonymous)]}>
<div className=\\"euiContextMenuPanel\\" onKeyDown={[Function]} tabIndex={-1} onAnimationEnd={[Function]}>
<div>
<EuiResizeObserver onResize={[Function: onResize]}>
<div>
Expand Down
Loading