[EuiDatePicker] Update ARIA and role attributes for better screen reader accessibility#5501
Merged
1Copenut merged 4 commits intoelastic:mainfrom Dec 28, 2021
1Copenut:feature/tpierce-eui-5303
Merged
[EuiDatePicker] Update ARIA and role attributes for better screen reader accessibility#55011Copenut merged 4 commits intoelastic:mainfrom 1Copenut:feature/tpierce-eui-5303
1Copenut merged 4 commits intoelastic:mainfrom
1Copenut:feature/tpierce-eui-5303
Conversation
1Copenut
added
accessibility
accessibility - screen reader
and removed
accessibility - cognition
labels
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5501/ |
chandlerprall
approved these changes
Dec 28, 2021
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM, compared this vs. main with mac's voiceover and saw almost no difference due to the verbosity of the live reasons. Did notice that the better-formatted "MMMM, YYYY" is read while tabbing off the calendar listbox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The calendar datepicker needed
role="option"added to the individual date choices and the time picker needed an accessible label. Also revised the accessible label for the calendar to closer match the time picker. Closes #5303.Checklist
Added documentation