Update elastic-charts to v41.0.1#5492
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5492/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5492/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5492/ |
|
Hmm I wonder why Renovate didn't initiate a PR for this |
cchaos
left a comment
There was a problem hiding this comment.
🙏 Thank you @nickofthyme for handling this upgrade! I cross-checked with the current published docs and it all looks the same. @thompsongl can most likely help get a specific backport for this for 7.17. It might be good to coordinate into one PR on the Kibana side.
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
cchaos
left a comment
There was a problem hiding this comment.
Erg, found one odd spot in the Copy/Paste code snippet.
That sounds good. I opened elastic/kibana#121593 to make the necessary changes in kibana but could upgrade eui with this fix in that pr. Then I can backport the pr into UpdateI added back the |
Yes, instead of removing the config value now, let's duplicate as necessary and mark it as deprecated. That will allow us to backport this upgrade to We can then do a follow-up PR with the breaking change removal and get that into a normal 8.x stack release. |
|
Ok then let me export that previous type and mark it as deprecated. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5492/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5492/ |
Summary
This PR upgrades
@elastic/chartstov41.0.1which included some breaking changes. Namely, the removal ofconfigfromPartitionSpec. EUI uses this config to set default properties on the shared eui charts theme, thus throws and errors withPartitionConfigbeing removed.The changes move all the old config overrides into the
theme.partitionsections which is a 1:1 match for all defined properties.