[EuiDataGrid] Fix cells losing focus state when scrolled out of view#5488
Merged
chandlerprall merged 8 commits intoelastic:mainfrom Dec 28, 2021
Merged
[EuiDataGrid] Fix cells losing focus state when scrolled out of view#5488chandlerprall merged 8 commits intoelastic:mainfrom
chandlerprall merged 8 commits intoelastic:mainfrom
Conversation
- will be used by cells to check if they're the currently focused cell
- by mounting with focus state (when cells scroll back into view)
- Remove mountEuiDataGridCellWithContext helper - the context wasn't actually getting used (it was falling back to the default context), and wasn't needed by most tests, and the tests that do need it can manually mount() with <DataGridFocusContext.Provider> as a wrapper
cee-chen
commented
Dec 16, 2021
cee-chen
commented
Dec 16, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5488/ |
- since the user is presumably already scrolling, there's no need to hijack their current scroll
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5488/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5488/ |
chandlerprall
approved these changes
Dec 28, 2021
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
LGTM! Tested in the preview, and confirmed the added test for { preventScroll: true } will catch regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #5047
Before
After
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Checked for breaking changes and labeled appropriately