[Docs][Proposal] Enable react-refresh in docs development#5475
Merged
chandlerprall merged 3 commits intoelastic:mainfrom Dec 16, 2021
Merged
[Docs][Proposal] Enable react-refresh in docs development#5475chandlerprall merged 3 commits intoelastic:mainfrom
chandlerprall merged 3 commits intoelastic:mainfrom
Conversation
chandlerprall
added
documentation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5475/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5475/ |
6 tasks
thompsongl
approved these changes
Dec 16, 2021
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
This looks great! I think it's worth it for the error overlay alone.
The results of my very unscientific testing show this doesn't add any discernible time to dev server startup or recompilation. Thanks for the comment clean up, as well.
Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5475/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables react-refresh, which builds on top of hot module replacement, to reload components during development instead of requiring a whole page refresh for some changes.
From testing, this prevents a full page reload when modifying components in
src. Utility files, service functions, etc, and documentation in src-docs still trigger a reload. But when it applies, the state retention is very nice:Error overlay
This also enables webpack's error overlay when there are compilation issues:
### Checklist