Skip to content
Merged
Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
3de3ce9
Provide rows for datagrid cells to be owned by
chandlerprall Sep 23, 2021
4594779
Merge branch 'master' into bug/4474-datagrid-row-accessibility
chandlerprall Sep 27, 2021
04d3ab5
changelog
chandlerprall Sep 27, 2021
9a6dc07
Merge branch 'master' into bug/4474-datagrid-row-accessibility
chandlerprall Oct 5, 2021
f786f5f
undoing things
chandlerprall Oct 5, 2021
06ac499
working except virtualized container
chandlerprall Oct 6, 2021
0129ea4
working row wrapper implementation
chandlerprall Oct 7, 2021
c05b457
Create datagrid row elements on-demand and render cells via portals
chandlerprall Oct 19, 2021
179da4a
Provide rows for datagrid cells to be owned by
chandlerprall Sep 23, 2021
24f5c53
changelog
chandlerprall Sep 27, 2021
a2ccb72
undoing things
chandlerprall Oct 5, 2021
eb4344c
working except virtualized container
chandlerprall Oct 6, 2021
535a2a9
working row wrapper implementation
chandlerprall Oct 7, 2021
9151350
Create datagrid row elements on-demand and render cells via portals
chandlerprall Oct 19, 2021
814feb1
Small style cleanup
chandlerprall Oct 19, 2021
95b7008
updated changelog
chandlerprall Oct 19, 2021
0ba3a02
updated changelog
chandlerprall Oct 19, 2021
1569aa0
fixing a bad changelog merge
chandlerprall Oct 19, 2021
9a6df52
oh that style was important
chandlerprall Oct 19, 2021
ae336f9
Update src/components/datagrid/body/data_grid_row_manager.ts
chandlerprall Oct 26, 2021
8dc8ad4
Update src/components/datagrid/data_grid_types.ts
chandlerprall Oct 26, 2021
7633c1b
Ensure unique ID in combobox with prepended or appended labels (#5229)
1Copenut Oct 19, 2021
c3e8b49
update i18ntokens
chandlerprall Oct 19, 2021
5ac481f
40.0.0
chandlerprall Oct 19, 2021
e0dd86e
Updated documentation.
chandlerprall Oct 19, 2021
ca721f2
Add combined Jest+Cypress code coverage reports (#5262)
constancecchen Oct 20, 2021
86af5ba
[EuiMarkdownEditor] Add `remark-breaks` and line break plugin (#5272)
i-a-n Oct 20, 2021
2553d89
[Docs] Separated out Borders to its own page & [EuiTableRowCell] fixe…
cchaos Oct 20, 2021
fdc387e
Fix CL from #5272
cchaos Oct 25, 2021
d468c85
[Docs] Update EuiDatePicker types (#5318)
thompsongl Oct 25, 2021
dea1eb9
[Cypress] Add flakey test retries + harden intermittent context menu …
constancecchen Oct 25, 2021
c995387
[Docs] Fix Colors guidelines (#5316)
thompsongl Oct 26, 2021
a60d734
Update dependency @elastic/charts to ^38.1.0 (#5321)
renovate[bot] Oct 26, 2021
ae515b6
PR feedback
chandlerprall Oct 26, 2021
f5b02ef
Added a cypress test for datagrid row rendering
chandlerprall Nov 1, 2021
82614cf
Merge branch 'master' into bug/4474-datagrid-row-accessibility-alternate
chandlerprall Nov 1, 2021
8336957
Merge branch 'master' into bug/4474-datagrid-row-accessibility-alternate
chandlerprall Nov 1, 2021
baa7b25
Revert changes(?) to docs/
chandlerprall Nov 1, 2021
937403e
revert changelog reformats
chandlerprall Nov 1, 2021
705edad
re-ignore a couple datagrid example pages when running a11y tests
chandlerprall Nov 2, 2021
55a5f95
Alternate way to know if the datagrid cells have rendered
chandlerprall Nov 3, 2021
420b37d
Merge branch 'main' into bug/4474-datagrid-row-accessibility-alternate
chandlerprall Nov 4, 2021
ad5c72b
PR feedback
chandlerprall Nov 4, 2021
6d10f54
changelog
chandlerprall Nov 5, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 6 additions & 0 deletions .babelrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,10 @@ module.exports = {
}
],
],
// Used for Cypress code coverage - note that the env has to be Cypress-specific, otherwise Jest --coverage throws errors
"env": {
"cypress_test": {
"plugins": ["istanbul"]
}
}
};
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ docs
packages
scripts
generator-eui
cypress
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ cypress/videos

coverage/
reports/
.nyc_output/
tmp/
dist/
lib/
Expand Down
23 changes: 23 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,31 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Added styling support for `valign` prop on `EuiTableRowCell` ([#5283](https://github.com/elastic/eui/pull/5283))
- Added `remark-breaks` plugin to mimic GitHub-flavored markdown line breaks within `EuiMarkdownEditor` ([#5272](https://github.com/elastic/eui/pull/5272))
- Removed `EuiErrorBoundary` from `EuiDatePicker` when unsupported props are used ([#5318](https://github.com/elastic/eui/pull/5318))

**Bug fixes**

- Fixed default text alignment in `EuiTableRowCell` on Safari ([#5283](https://github.com/elastic/eui/pull/5283))
- Fixed `mobileOptions.truncateText` from getting overridden by `truncateText` in `EuiTableRowCell` ([#5283](https://github.com/elastic/eui/pull/5283))

**Theme: Amsterdam**

- Fixed `mobileOptions.enlarge` styling in `EuiTableRowCell` ([#5283](https://github.com/elastic/eui/pull/5283))

## [`40.0.0`](https://github.com/elastic/eui/tree/v40.0.0)

- Updated `tokenKeyword` to match the definition of keyword field type ([#5251](https://github.com/elastic/eui/pull/5251))
- Added `element`, `buttonElement`, and `arrowProps` props to further customize `EuiAccordion` ([#5258](https://github.com/elastic/eui/pull/5258))

**Bug fixes**

- Fixed missing `id` for `EuiCombobox` by generating one if `prepend` or `append` exists ([#5229](https://github.com/elastic/eui/pull/5229))

**Bug fixes**

- Fixed an accessibility issue where `EuiDataGrid` cells weren't owned by `role=row` elements ([#5213](https://github.com/elastic/eui/pull/5285))
Comment thread
cee-chen marked this conversation as resolved.
Outdated

**Breaking changes**

- Renamed `tokenKeyword` icon to `tokenTag` in `EuiToken` ([#5251](https://github.com/elastic/eui/pull/5251))
Expand Down
4 changes: 4 additions & 0 deletions cypress.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,9 @@
"componentFolder": "src",
"testFiles": "**/*.spec.tsx",
"video": false
},
"retries": {
"runMode": 2,
"openMode": 0
}
}
19 changes: 6 additions & 13 deletions cypress/plugins/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,18 @@
*/

/// <reference types="cypress" />
// ***********************************************************
// This example plugins/index.js can be used to load plugins
//
// You can change the location of this file or turn off loading
// the plugins file with the 'pluginsFile' configuration option.
//
// You can read more here:
// https://on.cypress.io/plugins-guide
// ***********************************************************

// This function is called when a project is opened or re-opened (e.g. due to
// the project's config changing)
// @see https://on.cypress.io/plugins-guide

/**
* @type {Cypress.PluginConfig}
*/
// eslint-disable-next-line no-unused-vars
module.exports = (on, config) => {
// `on` is used to hook into various events Cypress emits
// `config` is the resolved Cypress config

require('@cypress/code-coverage/task')(on, config);
on('file:preprocessor', require('@cypress/code-coverage/use-babelrc'));

if (config.testingType === 'component') {
const { startDevServer } = require('@cypress/webpack-dev-server');

Expand All @@ -38,4 +29,6 @@ module.exports = (on, config) => {
startDevServer({ options, webpackConfig })
);
}

return config;
};
6 changes: 3 additions & 3 deletions cypress/plugins/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
const path = require('path');
const webpack = require('webpack');

const SRC_DIR = path.resolve(__dirname, '..', 'src');
const DIST_DIR = path.resolve(__dirname, '..', 'dist');

const plugins = [
// Force EuiIcon's dynamic imports to be included in the single eui.js build,
// instead of being split out into multiple files
Expand All @@ -37,6 +34,9 @@ module.exports = {
test: /\.(js|tsx?)$/,
loader: 'babel-loader',
exclude: /node_modules/,
options: {
plugins: ['istanbul'],
},
},
{
test: /\.scss$/,
Expand Down
1 change: 1 addition & 0 deletions cypress/support/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@
// https://on.cypress.io/configuration
// ***********************************************************

import '@cypress/code-coverage/support';
54 changes: 27 additions & 27 deletions docs/bundle.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/bundle.min.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/icon.accessibility.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/icon.accessibility.min.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/icon.aggregate.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading