Skip to content

[EuiMarkdownEditor] Add remark-breaks and line break plugin #5272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
i-a-n merged 3 commits into from
Oct 20, 2021
Merged

[EuiMarkdownEditor] Add remark-breaks and line break plugin #5272

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
106d299
Add remark-breaks and line break plugin to MarkdownEditor
i-a-n Oct 14, 2021
a810528
Update changelog
i-a-n Oct 20, 2021
4ae907c
Merge branch 'master' into markdown-plugin-breaks
i-a-n Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@
"rehype-raw": "^5.0.0",
"rehype-react": "^6.0.0",
"rehype-stringify": "^8.0.0",
"remark-breaks": "^2.0.2",
"remark-emoji": "^2.1.0",
"remark-parse": "^8.0.3",
"remark-rehype": "^8.0.0",
Expand Down
4 changes: 4 additions & 0 deletions src/components/markdown_editor/__snapshots__/markdown_editor.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ exports[`EuiMarkdownEditor custom plugins are excluded and popover is rendered 1
[Function],
Object {},
],
Array [
[Function],
Object {},
],
]
}
processingPluginList={
Expand Down
2 changes: 2 additions & 0 deletions src/components/markdown_editor/plugins/markdown_default_plugins/parsing_plugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {
} from 'unified';
import markdown from 'remark-parse';
import emoji from 'remark-emoji';
import breaks from 'remark-breaks';
import highlight from '../remark/remark_prismjs';
import * as MarkdownTooltip from '../markdown_tooltip';
import * as MarkdownCheckbox from '../markdown_checkbox';
Expand All @@ -39,6 +40,7 @@ export const getDefaultEuiMarkdownParsingPlugins = ({
[markdown, {}],
[highlight, {}],
[emoji, { emoticon: false }],
[breaks, {}],
[markdownLinkValidator, {}],
[MarkdownCheckbox.parser, {}],
];
Expand Down
7 changes: 7 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14433,6 +14433,13 @@ relateurl@^0.2.7:
resolved "https://registry.yarnpkg.com/relateurl/-/relateurl-0.2.7.tgz#54dbf377e51440aca90a4cd274600d3ff2d888a9"
integrity sha1-VNvzd+UUQKypCkzSdGANP/LYiKk=

remark-breaks@^2.0.2:
version "2.0.2"
resolved "https://registry.yarnpkg.com/remark-breaks/-/remark-breaks-2.0.2.tgz#55fdec6c7da84f659aa7fdb1aa95b632870cee8d"
integrity sha512-LsQnPPQ7Fzp9RTjj4IwdEmjPOr9bxe9zYKWhs9ZQOg9hMg8rOfeeqQ410cvVdIK87Famqza1CKRxNkepp2EvUA==
dependencies:
unist-util-visit "^2.0.0"

remark-emoji@^2.1.0:
version "2.1.0"
resolved "https://registry.yarnpkg.com/remark-emoji/-/remark-emoji-2.1.0.tgz#69165d1181b98a54ad5d9ef811003d53d7ebc7db"
Expand Down