[EuiCodeEditor] Add deprecation console warning#4984
Merged
thompsongl merged 12 commits intoelastic:masterfrom Jul 28, 2021
Merged
[EuiCodeEditor] Add deprecation console warning#4984thompsongl merged 12 commits intoelastic:masterfrom
thompsongl merged 12 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4984/ |
cchaos
reviewed
Jul 28, 2021
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
👍 Thanks for the quick turnaround. Mostly had some suggestions around wording of the callout.
chandlerprall
suggested changes
Jul 28, 2021
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Small requests on the test itself, everything else LGTM
Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4984/ |
This comment has been minimized.
This comment has been minimized.
cchaos
approved these changes
Jul 28, 2021
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Thanks for those updates! LGTM
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4984/ |
chandlerprall
approved these changes
Jul 28, 2021
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Thanks for setting this up! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds some updated recommendations for rendering code and a console warning noting the deprecation and future removal of
EuiCodeEditor. The warning looks as below in Kibana and only appears once when the component renders and will not appear multiple times on subsequent renders.The shortened link goes to the newly updated #3807
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes