[EuiLink] Amsterdam style boost and docs cleanup#4979
Merged
cchaos merged 8 commits intoelastic:masterfrom Jul 27, 2021
Merged
Conversation
added 5 commits
July 26, 2021 16:50
- Increased text underline weight on focus - Removed low-contrast focus background - Added `:visited` and `:target` styling (All mainly affecting Amsterdam)
cchaos
commented
Jul 26, 2021
| <EuiFlexGroup wrap responsive={false} gutterSize="xs"> | ||
| <EuiFlexItem grow={false}> | ||
| <EuiBadge color="#BADA55" href="/#/display/badge"> | ||
| <EuiBadge color="#BADA55" href="#/display/badge"> |
Contributor
Author
There was a problem hiding this comment.
Some docs changes was me fixing these urls
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4979/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4979/ |
elizabetdev
approved these changes
Jul 27, 2021
Contributor
elizabetdev
left a comment
elizabetdev
left a comment
There was a problem hiding this comment.
Tested in Chrome, Safari, Edge, and Firefox. I also looked at the code.
LGTM! 🎉
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4979/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4979/ |
cchaos
added a commit
to myasonik/eui
that referenced
this pull request
Jul 27, 2021
* [EuiLink] Increased font weight to match buttons - Increased text underline weight on focus - Removed low-contrast focus background - Added `:visited` and `:target` styling (All mainly affecting Amsterdam) * Re-use mixin in text styles
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4979/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style updates
I can't find the exact conversation, but there was someone from Cloud who suggested we at least increase the weight of our links so they're more detectable within paragraphs of text (other than color).
Since Amsterdam increased the font-weight of buttons to medium, we never did so to EuiLink. This PR adjusts that as well as some more of the focus states like increasing the thickness of the underline when normal
:focusbut the fulloutlinewhen:focus-visible. The thicker underline is also shown when it is:target.Before/After for Amsterdam
Before/After default theme
This remains mostly untouched, but does fix the ghost focus state.
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs and playground toggles[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately