[EuiSearchBar] Handle 0 count after manual query manipulation#4977
Merged
thompsongl merged 3 commits intoelastic:masterfrom Jul 26, 2021
Merged
[EuiSearchBar] Handle 0 count after manual query manipulation#4977thompsongl merged 3 commits intoelastic:masterfrom
thompsongl merged 3 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4977/ |
myasonik
approved these changes
Jul 26, 2021
Contributor
myasonik
left a comment
myasonik
left a comment
There was a problem hiding this comment.
LGTM!
Tested in FF and code review
cchaos
pushed a commit
to myasonik/eui
that referenced
this pull request
Jul 27, 2021
…c#4977) * handle 0 count * CL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4976 by marking a filter as inactive when the number of active filters drops to 0.
See repro steps in the issue.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes