Skip to content

[Elastic Charts] Added value labels styles for bar charts #4845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elizabetdev merged 22 commits into from
Sep 16, 2021
Merged

[Elastic Charts] Added value labels styles for bar charts #4845

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2cd5539
Adding new theme value labels styling
elizabetdev Jun 1, 2021
c09bfdf
Merge remote-tracking branch 'upstream/master' into xy-chart-theme-va…
elizabetdev Jul 16, 2021
6c4e731
Merge remote-tracking branch 'upstream/master' into xy-chart-theme-va…
elizabetdev Jul 26, 2021
e1f3f7c
Setting `textBorder` to zero
elizabetdev Jul 26, 2021
9382384
Merge remote-tracking branch 'upstream/master' into xy-chart-theme-va…
elizabetdev Jul 26, 2021
56a8aab
Adding `showValueLabels` field in MultiChartCard
elizabetdev Jul 26, 2021
7a3f23d
Increase category chart height
elizabetdev Jul 27, 2021
20e86ea
Adding center alignment
elizabetdev Jul 27, 2021
90166c3
CL
elizabetdev Jul 27, 2021
69e1ab3
Shared comp improvement
elizabetdev Jul 27, 2021
8d1242f
Update CHANGELOG.md
elizabetdev Jul 28, 2021
f63de66
Merge remote-tracking branch 'upstream/master' into xy-chart-theme-va…
elizabetdev Jul 28, 2021
7973a88
Adding value labels card and config text to copy.
elizabetdev Jul 28, 2021
a5c0094
Merge remote-tracking branch 'upstream/master' into xy-chart-theme-va…
elizabetdev Jul 28, 2021
e82929f
Merge remote-tracking branch 'upstream/master' into xy-chart-theme-va…
elizabetdev Sep 9, 2021
9ea28f2
Adding multi and stacked centered
elizabetdev Sep 9, 2021
924eaf8
CL
elizabetdev Sep 9, 2021
91e91f5
Adding better data for multi series and removing lodash orderBy
elizabetdev Sep 9, 2021
d3c215c
Better indentation
elizabetdev Sep 9, 2021
2833783
Merge remote-tracking branch 'upstream/master' into xy-chart-theme-va…
elizabetdev Sep 9, 2021
9a19371
Custom theme only when value labels. Small styles fixes.
elizabetdev Sep 16, 2021
467370e
Merge remote-tracking branch 'upstream/master' into xy-chart-theme-va…
elizabetdev Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
"@babel/preset-env": "^7.11.0",
"@babel/preset-react": "^7.10.4",
"@babel/preset-typescript": "^7.12.1",
"@elastic/charts": "^24.5.1",
"@elastic/charts": "^29.2.0",
"@elastic/datemath": "^5.0.3",
"@elastic/eslint-config-kibana": "^0.15.0",
"@svgr/core": "5.4.0",
Expand Down
8 changes: 6 additions & 2 deletions src/themes/charts/themes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,13 @@ function createTheme(colors: any): EuiChartThemeType {
},
barSeriesStyle: {
displayValue: {
fontSize: 8,
fontSize: 10,

@markov00 markov00 Sep 13, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also set a min and max font size, the code automatically uses the right size depending on the available space.

fontFamily: fontFamily,
fill: colors.euiColorDarkShade.rgba,
fill: {
textInvertible: true,
textContrast: true,
textBorder: 0.5,
Comment thread
cchaos marked this conversation as resolved.
Outdated
},
},
},
scales: {
Expand Down
21 changes: 17 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,15 +1009,16 @@
exec-sh "^0.3.2"
minimist "^1.2.0"

"@elastic/charts@^24.5.1":
version "24.5.1"
resolved "https://registry.yarnpkg.com/@elastic/charts/-/charts-24.5.1.tgz#4757721b0323b15412c92d696dd76fdef9b963f8"
integrity sha512-eHJna3xyHREaSfTRb+3/34EmyoINopH6yP9KReakXRb0jW8DD4n9IkbPFwpVN3uXQ6ND2x1ObA0ZzLPSLCPozg==
"@elastic/charts@^29.2.0":
version "29.2.0"
resolved "https://registry.yarnpkg.com/@elastic/charts/-/charts-29.2.0.tgz#cd65887c0ca1d420493aee1b570c862ca0df5311"
integrity sha512-gj3Gew9zy8XPNEkAAznOjncO5AF63jy/X1k1VIcNPqdqMi07YYCZwCQjMzUVoS4RN6X4GSzxhrYfGAeyZP8gqg==
dependencies:
"@popperjs/core" "^2.4.0"
chroma-js "^2.1.0"
classnames "^2.2.6"
d3-array "^1.2.4"
d3-cloud "^1.2.5"
d3-collection "^1.0.7"
d3-color "^1.4.0"
d3-interpolate "^1.4.0"
Expand Down Expand Up @@ -4756,6 +4757,13 @@ d3-array@^1.2.0, d3-array@^1.2.4:
resolved "https://registry.yarnpkg.com/d3-array/-/d3-array-1.2.4.tgz#635ce4d5eea759f6f605863dbcfc30edc737f71f"
integrity sha512-KHW6M86R+FUPYGb3R5XiYjXPq7VzwxZ22buHhAEVG5ztoEcZZMLov530mmccaqA1GghZArjQV46fuc8kUqhhHw==

d3-cloud@^1.2.5:
version "1.2.5"
resolved "https://registry.yarnpkg.com/d3-cloud/-/d3-cloud-1.2.5.tgz#3e91564f2d27fba47fcc7d812eb5081ea24c603d"
integrity sha512-4s2hXZgvs0CoUIw31oBAGrHt9Kt/7P9Ik5HIVzISFiWkD0Ga2VLAuO/emO/z1tYIpE7KG2smB4PhMPfFMJpahw==
dependencies:
d3-dispatch "^1.0.3"

d3-collection@1, d3-collection@^1.0.7:
version "1.0.7"
resolved "https://registry.yarnpkg.com/d3-collection/-/d3-collection-1.0.7.tgz#349bd2aa9977db071091c13144d5e4f16b5b310e"
Expand All @@ -4766,6 +4774,11 @@ d3-color@1, d3-color@^1.4.0:
resolved "https://registry.yarnpkg.com/d3-color/-/d3-color-1.4.1.tgz#c52002bf8846ada4424d55d97982fef26eb3bc8a"
integrity sha512-p2sTHSLCJI2QKunbGb7ocOh7DgTAn8IrLx21QRc/BSnodXM4sv6aLQlnfpvehFMLZEfBc6g9pH9SWQccFYfJ9Q==

d3-dispatch@^1.0.3:
version "1.0.6"
resolved "https://registry.yarnpkg.com/d3-dispatch/-/d3-dispatch-1.0.6.tgz#00d37bcee4dd8cd97729dd893a0ac29caaba5d58"
integrity sha512-fVjoElzjhCEy+Hbn8KygnmMS7Or0a9sI2UzGwoB7cCtvI1XpVN9GpoYlnb3xt2YV66oXYb1fLJ8GMvP4hdU1RA==

d3-format@1:
version "1.4.5"
resolved "https://registry.yarnpkg.com/d3-format/-/d3-format-1.4.5.tgz#374f2ba1320e3717eb74a9356c67daee17a7edb4"
Expand Down