[EuiPopover] Handle initialFocus
#4768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4768/ |
chandlerprall
approved these changes
Apr 29, 2021
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM! Verified the popfirst change works as expected in the form layouts' inline popover example.
cchaos
pushed a commit
that referenced
this pull request
May 4, 2021
* use hasSetInitialFocus * revert me * Revert "revert me" This reverts commit 011ed24. * docs * CL
7 tasks
This was referenced Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4767, where it was discovered that
EuiPopoverwould exit early from its method to set initial focus, causing theinitialFocusprop to be disregarded.The fix here is to ensure that focus has been intentionally set, not just that any element has focus.
falseis now an option forintialFocusto allow consumers to opt-out of initial auto-focus while maintaining focus trapping.Wasn't able to write a test that actually worked.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Added or updated jest tests