Skip to content

[Docs] Show all HTMLAttributes types#4659

Merged
thompsongl merged 1 commit intoelastic:masterfrom
thompsongl:props-table-extendedtypes
Mar 23, 2021
Merged

[Docs] Show all HTMLAttributes types#4659
thompsongl merged 1 commit intoelastic:masterfrom
thompsongl:props-table-extendedtypes

Conversation

@thompsongl
Copy link
Contributor

Summary

Show all HTMLAttributes type extensions unless there is more appropriate custom type extension

### Checklist

@thompsongl thompsongl added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) labels Mar 22, 2021
@thompsongl thompsongl requested a review from cchaos March 22, 2021 16:52
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4659/

@cchaos
Copy link
Contributor

cchaos commented Mar 22, 2021

Is there a good example of this one in master to check?

@thompsongl
Copy link
Contributor Author

Is there a good example of this one in master to check?

EuiPanel. It was limited to HTMLButtonElement prior to your EuiCard refactor PR

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, yep. I had thought it was because of my PR. 👍 LGTM and thank you!

@thompsongl thompsongl merged commit d259ee8 into elastic:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants