Skip to content
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ No public interface changes since `31.9.1`.
**Bug fixes**

- Fixed an errant export of two non-existant values ([#4597](https://github.com/elastic/eui/pull/4564597))
- Fixed `EuiDataGrid` retaining cells style when column position is changed ([#4601](https://github.com/elastic/eui/pull/4601))

## [`31.9.0`](https://github.com/elastic/eui/tree/v31.9.0)

Expand Down
7 changes: 7 additions & 0 deletions src-docs/src/views/datagrid/datagrid.js
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,13 @@ export default () => {
});
}
}
return () => {
setCellProps({
style: {
backgroundColor: 'transparent',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it to @chandlerprall or @thompsongl on whether it's best to address this at the docs layer or in the component itself, but I think we're going to want to set this to the $euiColorEmptyShade color rather than transparent. This would be needed since the panel might carry a background.

image

},
});
};
}, [rowIndex, columnId, setCellProps, data]);

function getFormatted() {
Expand Down
7 changes: 7 additions & 0 deletions src-docs/src/views/datagrid/footer_row.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,13 @@ export default () => {
});
}
}
return () => {
setCellProps({
style: {
backgroundColor: 'transparent',
},
});
};
}, [rowIndex, columnId, setCellProps]);

return raw_data.hasOwnProperty(rowIndex)
Expand Down