Skip to content

Remove type exports from index.js#4559

Merged
thompsongl merged 1 commit intoelastic:masterfrom
thompsongl:hotfix/types
Feb 20, 2021
Merged

Remove type exports from index.js#4559
thompsongl merged 1 commit intoelastic:masterfrom
thompsongl:hotfix/types

Conversation

@thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Feb 20, 2021 •
edited
Loading

Summary

Rolling back index.js to just before #4517 merged.

A build should not have any output in the form of:

WARNING in ./components/color_picker/index.ts 23:0-66
"export 'EuiColorStopsProps' was not found in './color_stops'
 @ ./components/index.js
 @ ./index.js

### Checklist

chandlerprall
chandlerprall approved these changes Feb 20, 2021
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kibanamachine
Copy link

kibanamachine commented Feb 20, 2021

Preview documentation changes for this PR: https://eui.elastic.co/pr_4559/

@thompsongl thompsongl merged commit c6857e0 into elastic:master Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chandlerprall chandlerprall chandlerprall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thompsongl @kibanamachine @chandlerprall