[EuiPopover] Added will-change via JS to help with fuzzy animation#4527
[EuiPopover] Added will-change via JS to help with fuzzy animation#4527cchaos merged 4 commits intoelastic:masterfrom
will-change via JS to help with fuzzy animation#4527Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4527/ |
|
One oddity that I noticed in Safari is the the contents of the super date picker's popover blinks upon opening. I checked with the published docs though and it's happening there too, so it's not related to this change. Screen.Recording.2021-02-16.at.12.48.21.PM.mp4 |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4527/ |
chandlerprall
left a comment
There was a problem hiding this comment.
Added a question, but this LGTM! I don't see any reason to avoid will-change in these instances.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4527/ |
snide
left a comment
There was a problem hiding this comment.
Tested and checked code. LGTM.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4527/ |
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4527/ |
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4527/ |
Fixes #4521
According to these two links:
The best way to enhance animations in the browser is with
will-changebut adding this statically to class in CSS is costly so it's best to add it via JS only on instantiation. Luckily, we already were applying astyleprop to the EuiPopover panel only when mounted so it was an obvious place to add this property.before
Screen.Recording.2021-02-16.at.12.44.32.PM.mp4
after
Screen.Recording.2021-02-16.at.12.45.22.PM.mp4
Checklist
[ ] Props have proper autodocs and playground toggles[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes