Skip to content

[EuiDatePicker] Fixed the bug of not seeing difference between the disabled/non-disabled times#4524

Merged
cchaos merged 11 commits intoelastic:masterfrom
anuragxxd:EUIDatePicker
Feb 17, 2021
Merged

[EuiDatePicker] Fixed the bug of not seeing difference between the disabled/non-disabled times#4524
cchaos merged 11 commits intoelastic:masterfrom
anuragxxd:EUIDatePicker

Conversation

@anuragxxd
Copy link
Contributor

@anuragxxd anuragxxd commented Feb 15, 2021

Summary

Fixed the bug of not seeing difference between the disabled/non-disabled times. ISSUE LINK
Solved it by commenting one css property it was overriding the blur effect.

Before:-
1

After:-
2

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs and playground toggles
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Feb 15, 2021

💚 CLA has been signed

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Welcome @git-anurag-hub !

If you haven't already, you please sign the CLA linked below. Be sure to use the same email address linked to your Github account.

@anuragxxd
Copy link
Contributor Author

Made the change you asked for. :)
@cchaos

@cchaos
Copy link
Contributor

cchaos commented Feb 17, 2021

Thanks, I'll get our CI (Jenkins) started for you which will run our tests and get a preview built.

Jenkins, test this

@cchaos
Copy link
Contributor

cchaos commented Feb 17, 2021

In the meantime, this PR will need a Changelog entry. You can follow the pattern already established in the CHANGELOG.md file.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4524/

@anuragxxd
Copy link
Contributor Author

Done with CHANGELOG.md @cchaos

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @git-anurag-hub. Just one more fix for your current changes.

@anuragxxd
Copy link
Contributor Author

Np @cchaos

anuragxxd and others added 3 commits February 17, 2021 23:51
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
@cchaos
Copy link
Contributor

cchaos commented Feb 17, 2021

Jenkins, test this

@cchaos
Copy link
Contributor

cchaos commented Feb 17, 2021

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4524/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants