[EuiAccordion] Added buttonProps to pass the <button> element#4510
Merged
cchaos merged 5 commits intoelastic:masterfrom Feb 10, 2021
Merged
[EuiAccordion] Added buttonProps to pass the <button> element#4510cchaos merged 5 commits intoelastic:masterfrom
buttonProps to pass the <button> element#4510cchaos merged 5 commits intoelastic:masterfrom
Conversation
added 3 commits
February 10, 2021 13:35
Also in turn, passes this down to the EuiAccordion rendered by EuiCollapsibleNav
…_nav_button_props
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4510/ |
1 similar comment
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4510/ |
chandlerprall
approved these changes
Feb 10, 2021
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
One teeny request, then this LGTM!
Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4510/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4510/ |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also in turn, passes this down to the EuiAccordion rendered by EuiCollapsibleNav
Fixes #4499
Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in mobile[ ] Checked in Chrome, Safari, Edge, and Firefox[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes