Add background to data grid content. Add more params to euiScrollBar#4509
Merged
chandlerprall merged 6 commits intoelastic:masterfrom Feb 11, 2021
Merged
Add background to data grid content. Add more params to euiScrollBar#4509chandlerprall merged 6 commits intoelastic:masterfrom
chandlerprall merged 6 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4509/ |
Contributor
Author
|
@chandlerprall This is a pretty simple one, but can you please verify that removing the scrollbar height is ok? I couldn't find any usage where it needed to be part of the calculation. It looked like it was extraneous. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4509/ |
chandlerprall
approved these changes
Feb 11, 2021
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Woohoo! Love that scrollbar height going away, confirmed it isn't needed anymore.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4509/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4509/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EuiDataGridcontent. This is helpful for when it is in virutalized mode.mixin euiScrollBarto allow for customizing coloring.After
Before
I will consult with @cchaos later today for some styling feedback.
Checklist
[ ] Props have proper autodocs and playground togglesChecked Code Sandbox works for the any docs examplesAdded or updated jest testsChecked for breaking changes and labeled appropriatelyChecked for accessibility including keyboard-only and screenreader modes